Re: [Qemu-devel] [PATCH v6 17/29] ahci-test: Drop dependence on global_qtest

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

On 09/05/2017 05:32 AM, Thomas Huth wrote:
> On 01.09.2017 20:03, Eric Blake wrote:
>> Managing parallel connections to two different monitors via
>> the implicit global_qtest makes it hard to copy-and-paste code
>> to tests that are not aware of the implicit state; the
>> management of global_qtest is even harder to follow because
>> it was masked behind set_context().
>>

>> ---
>>  tests/libqos/libqos.h    |  1 -
>>  tests/ahci-test.c        | 83 +++++++++++++++++++++++-------------------------
>>  tests/libqos/ahci.c      | 45 +++++++++++++-------------
>>  tests/libqos/libqos-pc.c |  2 +-
>>  tests/libqos/libqos.c    | 37 ++++++---------------
>>  5 files changed, 73 insertions(+), 95 deletions(-)
> 
> Might be easier to review if you'd split the changes to libqos.c into a
> separate patch. But anyway:
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>

I'll split it, even though it means dropping R-b on both halves of the
split (so you can make sure the pieces still look sane).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]