Re: [PATCH] tests/functional/m68k: Use proper polling in the next-cube test

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 9/9/25 09:48, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> The next-cube tests currently sleep for 2 seconds to wait for the
> guest's display to come up with the expected results. That's bad
> since there is still a theoretical race left here, and since there
> are two subtests, the whole test takes more than 4 seconds this way.
> 
> Looking at what the firmware does, there is a better way instead of
> blindly waiting for two seconds: The firmware is writing some values
> to the FPU registers during a test (and never touches them again
> afterwards, so we can be sure about the final values), so we can
> poll for the right values in those registers to know when we reached
> a state when the display is initialized for sure. We just have to
> also make sure to not look for text anymore that is only printed
> after the FPU test has been done by the guest firmware.
> 
> This way the whole tests finishes in less than 1 second here, and
> there should be no race condition here anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/functional/m68k/test_nextcube.py | 17 ++++++++++++-----
>   1 file changed, 12 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>