From: Laurent Vivier <laurent@vivier.eu>
To: Zhang Chen <chen.zhang@intel.com>,
Xie Changlong <xiechanglong.d@gmail.com>,
Wen Congyang <wencongyang2@huawei.com>,
qemu-trivial@nongnu.org
Cc: Lukas Straub <lukasstraub2@web.de>, qemu-dev <qemu-devel@nongnu.org>
Subject: Re: [PATCH] docs/block-replication.txt: Fix replication top-id command demo
Date: Fri, 17 Dec 2021 11:25:17 +0100 [thread overview]
Message-ID: <86d06356-7ce8-ec33-29bc-df3e10ffc416@vivier.eu> (raw)
In-Reply-To: <20211018085044.2788276-1-chen.zhang@intel.com>
Le 18/10/2021 à 10:50, Zhang Chen a écrit :
> This demo not correct, the original childs1 can't pass the
> the bdrv_is_root_node check in replcation_start().
> Keep consistent with docs/COLO-FT.txt
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> ---
> docs/block-replication.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/block-replication.txt b/docs/block-replication.txt
> index 108e9166a8..66ad540676 100644
> --- a/docs/block-replication.txt
> +++ b/docs/block-replication.txt
> @@ -179,7 +179,7 @@ Primary:
>
> Secondary:
> -drive if=none,driver=raw,file.filename=1.raw,id=colo1 \
> - -drive if=none,id=childs1,driver=replication,mode=secondary,top-id=childs1
> + -drive if=none,id=childs1,driver=replication,mode=secondary,top-id=top-disk1
> file.file.filename=active_disk.qcow2,\
> file.driver=qcow2,\
> file.backing.file.filename=hidden_disk.qcow2,\
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2021-12-17 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 8:50 [PATCH] docs/block-replication.txt: Fix replication top-id command demo Zhang Chen
2021-11-18 6:01 ` Zhang, Chen
2021-12-17 10:25 ` Laurent Vivier [this message]
2021-12-17 10:35 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d06356-7ce8-ec33-29bc-df3e10ffc416@vivier.eu \
--to=laurent@vivier.eu \
--cc=chen.zhang@intel.com \
--cc=lukasstraub2@web.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).