From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: sw@weilnetz.de, luoyonggang@gmail.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] file-win32: Fix "locking" option
Date: Mon, 7 Sep 2020 12:13:21 +0200 [thread overview]
Message-ID: <86e6c93f-88db-93f8-e76d-0b02e88b7b8e@redhat.com> (raw)
In-Reply-To: <20200907092739.9988-1-kwolf@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 734 bytes --]
On 07.09.20 11:27, Kevin Wolf wrote:
> The intended behaviour was that locking=off/auto work and have no
> effect (to remain compatible with file-posix), whereas locking=on would
> return an error. Unfortunately, the code forgot to remove "locking" from
> the options QDict, so any attempt to use the option would fail.
>
> Replace the option parsing code for "locking" with something that is
> part of the raw_runtime_opts QemuOptsList (so it is properly removed
> from the QDict) and looks more like file-posix.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/file-win32.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-09-07 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 9:27 [PATCH] file-win32: Fix "locking" option Kevin Wolf
2020-09-07 9:35 ` Philippe Mathieu-Daudé
2020-09-07 10:13 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86e6c93f-88db-93f8-e76d-0b02e88b7b8e@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).