From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BBD0C2D0EC for ; Wed, 8 Apr 2020 00:30:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3557C20730 for ; Wed, 8 Apr 2020 00:30:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3557C20730 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLybr-0005sU-92 for qemu-devel@archiver.kernel.org; Tue, 07 Apr 2020 20:30:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53566) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLyau-0005A1-Kn for qemu-devel@nongnu.org; Tue, 07 Apr 2020 20:29:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLyas-0000HR-MS for qemu-devel@nongnu.org; Tue, 07 Apr 2020 20:29:27 -0400 Received: from mga06.intel.com ([134.134.136.31]:1702) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLyas-0000Cy-DD for qemu-devel@nongnu.org; Tue, 07 Apr 2020 20:29:26 -0400 IronPort-SDR: SwB4JsStvTAN+bnzX1NtNir6mF427n5lJN4dIQz58Rri9vLbfxH6xrs+Ux50FLPRwhAQLexoz6 4IX1wsv10CgQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2020 17:29:16 -0700 IronPort-SDR: vt6PAvqYUHmG6RblNGVJHxeJzjuzhxGUDksZT+BSD4wd6d4vlxHJTj/M3eABRE9afGyDezJntX yiq3eyLySkXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,357,1580803200"; d="scan'208";a="286386917" Received: from txu2-mobl.ccr.corp.intel.com (HELO [10.238.4.86]) ([10.238.4.86]) by fmsmga002.fm.intel.com with ESMTP; 07 Apr 2020 17:29:14 -0700 Subject: Re: [PATCH v4] target/i386: Add notes for versioned CPU models To: "ehabkost@redhat.com" References: <20200324051034.30541-1-tao3.xu@intel.com> From: Tao Xu Message-ID: <86f75c9e-a29f-dbae-1414-5fd06f981fed@intel.com> Date: Wed, 8 Apr 2020 08:29:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200324051034.30541-1-tao3.xu@intel.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 134.134.136.31 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "pbonzini@redhat.com" , "qemu-devel@nongnu.org" , "rth@twiddle.net" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Ping for comments On 3/24/2020 1:10 PM, Xu, Tao3 wrote: > Add which features are added or removed in this version. > > Signed-off-by: Tao Xu > --- > > The output is as follows: > qemu-system-x86_64 -cpu help | grep "\[" > x86 Cascadelake-Server-v2 Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES] > x86 Cascadelake-Server-v3 Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES, no TSX] > x86 Denverton-v2 Intel Atom Processor (Denverton) [no MPX, no MONITOR] > x86 Icelake-Client-v2 Intel Core Processor (Icelake) [no TSX] > x86 Icelake-Server-v2 Intel Xeon Processor (Icelake) [no TSX] > > Changes in v3: > - Keep the existing custom model-id (Eduardo) > > Changes in v2: > - correct the note of Cascadelake v3 (Xiaoyao) > --- > target/i386/cpu.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 34b511f078..1c7690baa0 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -3192,6 +3192,7 @@ static X86CPUDefinition builtin_x86_defs[] = { > .versions = (X86CPUVersionDefinition[]) { > { .version = 1 }, > { .version = 2, > + .note = "ARCH_CAPABILITIES", > .props = (PropValue[]) { > { "arch-capabilities", "on" }, > { "rdctl-no", "on" }, > @@ -3203,6 +3204,7 @@ static X86CPUDefinition builtin_x86_defs[] = { > }, > { .version = 3, > .alias = "Cascadelake-Server-noTSX", > + .note = "ARCH_CAPABILITIES, no TSX", > .props = (PropValue[]) { > { "hle", "off" }, > { "rtm", "off" }, > @@ -3424,6 +3426,7 @@ static X86CPUDefinition builtin_x86_defs[] = { > { .version = 1 }, > { > .version = 2, > + .note = "no TSX", > .alias = "Icelake-Client-noTSX", > .props = (PropValue[]) { > { "hle", "off" }, > @@ -3541,6 +3544,7 @@ static X86CPUDefinition builtin_x86_defs[] = { > { .version = 1 }, > { > .version = 2, > + .note = "no TSX", > .alias = "Icelake-Server-noTSX", > .props = (PropValue[]) { > { "hle", "off" }, > @@ -3648,6 +3652,7 @@ static X86CPUDefinition builtin_x86_defs[] = { > { .version = 1 }, > { > .version = 2, > + .note = "no MPX, no MONITOR", > .props = (PropValue[]) { > { "monitor", "off" }, > { "mpx", "off" }, >