From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [RFC PATCH-for-10.1 11/19] accel/tcg: Replace CPU_RESOLVING_TYPE -> target_cpu_type()
Date: Fri, 4 Apr 2025 09:51:36 -0700 [thread overview]
Message-ID: <86fe4d7f-f0cd-42b9-99f0-b802337657b2@linaro.org> (raw)
In-Reply-To: <20250403234914.9154-12-philmd@linaro.org>
On 4/3/25 16:49, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> accel/tcg/tcg-all.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c
> index bf27c5c0fb3..a13cb39644f 100644
> --- a/accel/tcg/tcg-all.c
> +++ b/accel/tcg/tcg-all.c
> @@ -35,6 +35,7 @@
> #include "qapi/qapi-types-common.h"
> #include "qapi/qapi-builtin-visit.h"
> #include "qemu/units.h"
> +#include "qemu/target_info.h"
> #if defined(CONFIG_USER_ONLY)
> #include "hw/qdev-core.h"
> #else
> @@ -44,7 +45,6 @@
> #include "accel/tcg/cpu-ops.h"
> #include "internal-common.h"
> #include "cpu-param.h"
> -#include "cpu.h"
>
>
> struct TCGState {
> @@ -73,7 +73,7 @@ bool qemu_tcg_mttcg_enabled(void)
>
> static void mttcg_init(TCGState *s)
> {
> - CPUClass *cc = CPU_CLASS(object_class_by_name(CPU_RESOLVING_TYPE));
> + CPUClass *cc = CPU_CLASS(object_class_by_name(target_cpu_type()));
> bool mttcg_supported = cc->tcg_ops->mttcg_supported;
>
> if (s->mttcg_enabled == ON_OFF_AUTO_AUTO) {
It can be squashed with previous commit.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
next prev parent reply other threads:[~2025-04-04 17:14 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 23:48 [RFC PATCH-for-10.1 00/19] qemu: Introduce TargetInfo API (for single binary) Philippe Mathieu-Daudé
2025-04-03 23:48 ` [RFC PATCH-for-10.1 01/19] qemu: Introduce TargetInfo API in 'target_info.h' Philippe Mathieu-Daudé
2025-04-04 16:41 ` Pierrick Bouvier
2025-04-03 23:48 ` [RFC PATCH-for-10.1 02/19] qemu: Convert target_name() to TargetInfo API Philippe Mathieu-Daudé
2025-04-04 16:42 ` Pierrick Bouvier
2025-04-03 23:48 ` [RFC PATCH-for-10.1 03/19] qemu: Factor target_system_arch() out Philippe Mathieu-Daudé
2025-04-04 16:44 ` Pierrick Bouvier
2025-04-03 23:48 ` [RFC PATCH-for-10.1 04/19] qemu: Convert target_words_bigendian() to TargetInfo API Philippe Mathieu-Daudé
2025-04-04 16:45 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 05/19] qemu: Introduce target_long_bits() Philippe Mathieu-Daudé
2025-04-04 16:46 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 06/19] target/tricore: Replace TARGET_LONG_BITS -> target_long_bits() Philippe Mathieu-Daudé
2025-04-04 16:48 ` Pierrick Bouvier
2025-04-04 17:53 ` Philippe Mathieu-Daudé
2025-04-17 18:00 ` Paolo Bonzini
2025-04-17 18:32 ` Philippe Mathieu-Daudé
2025-04-03 23:49 ` [RFC PATCH-for-10.1 07/19] target/hppa: " Philippe Mathieu-Daudé
2025-04-04 16:48 ` Pierrick Bouvier
2025-04-04 17:54 ` Philippe Mathieu-Daudé
2025-04-17 17:27 ` Paolo Bonzini
2025-04-03 23:49 ` [RFC PATCH-for-10.1 08/19] target/riscv: " Philippe Mathieu-Daudé
2025-04-04 16:48 ` Pierrick Bouvier
2025-04-04 17:54 ` Philippe Mathieu-Daudé
2025-04-03 23:49 ` [RFC PATCH-for-10.1 09/19] qemu: Introduce target_cpu_type() Philippe Mathieu-Daudé
2025-04-04 16:48 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 10/19] cpus: Replace CPU_RESOLVING_TYPE -> target_cpu_type() Philippe Mathieu-Daudé
2025-04-04 16:51 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 11/19] accel/tcg: " Philippe Mathieu-Daudé
2025-04-04 16:51 ` Pierrick Bouvier [this message]
2025-04-04 17:56 ` Philippe Mathieu-Daudé
2025-04-04 18:04 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 12/19] cpus: Move target-agnostic methods out of cpu-target.c Philippe Mathieu-Daudé
2025-04-04 16:53 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 13/19] accel: Replace CPU_RESOLVING_TYPE -> target_cpu_type() Philippe Mathieu-Daudé
2025-04-04 16:52 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 14/19] accel: Implement accel_init_ops_interfaces() for both system/user mode Philippe Mathieu-Daudé
2025-04-04 16:56 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 15/19] accel: Include missing 'qemu/accel.h' header in accel-internal.h Philippe Mathieu-Daudé
2025-04-04 16:56 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 16/19] accel: Make AccelCPUClass structure target-agnostic Philippe Mathieu-Daudé
2025-04-04 16:57 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 17/19] accel: Move target-agnostic code from accel-target.c -> accel-common.c Philippe Mathieu-Daudé
2025-04-04 16:59 ` Pierrick Bouvier
2025-04-17 16:42 ` Philippe Mathieu-Daudé
2025-04-03 23:49 ` [RFC PATCH-for-10.1 18/19] qemu: Prepare per-binary QOM filter via TYPE_BINARY_PREFIX Philippe Mathieu-Daudé
2025-04-04 17:04 ` Pierrick Bouvier
2025-04-03 23:49 ` [RFC PATCH-for-10.1 19/19] system/vl: Filter machine list for binary using machine_binary_filter() Philippe Mathieu-Daudé
2025-04-04 17:10 ` Pierrick Bouvier
2025-04-04 18:01 ` Philippe Mathieu-Daudé
2025-04-04 18:08 ` Pierrick Bouvier
2025-04-04 18:11 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fe4d7f-f0cd-42b9-99f0-b802337657b2@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).