From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94126C00454 for ; Thu, 12 Dec 2019 15:04:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AD9F206C3 for ; Thu, 12 Dec 2019 15:04:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JxQd6eG7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AD9F206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifQ0m-0007Qk-Fu for qemu-devel@archiver.kernel.org; Thu, 12 Dec 2019 10:04:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42273) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifPzZ-0006QN-Au for qemu-devel@nongnu.org; Thu, 12 Dec 2019 10:03:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifPzX-0000nI-Jz for qemu-devel@nongnu.org; Thu, 12 Dec 2019 10:03:00 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:41904 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ifPzX-0000lh-F9 for qemu-devel@nongnu.org; Thu, 12 Dec 2019 10:02:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576162978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gjig8mqgAVYoxXAxIeM6/MIiGck0O1bD7+cMH+sE2mM=; b=JxQd6eG775g9Q8xj97PaoRWbpyXqZvnNGWwX5As+rlejFxZi6i+Mag/6AuFDRiu7F4LSBN TSr5tq8KOYnyI2of7lgtzTmK31/D+myRThtes92iwIdBin81tW785md/S416ARs9fdWT1S GQY9Edt45fSydfBY/p3FoKtorQd0944= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-YOWX_D8xOjmSag0QA5D6xg-1; Thu, 12 Dec 2019 10:02:55 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AD36E107AD53; Thu, 12 Dec 2019 15:02:53 +0000 (UTC) Received: from [10.3.116.171] (ovpn-116-171.phx2.redhat.com [10.3.116.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BA5E6764C; Thu, 12 Dec 2019 15:02:51 +0000 (UTC) Subject: Re: [PATCH] qcow2: Use offset_into_cluster() To: Alberto Garcia , qemu-devel@nongnu.org References: <20191212100121.29621-1-berto@igalia.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <8702f7a1-746f-49ec-e404-47318d21f7e3@redhat.com> Date: Thu, 12 Dec 2019 09:02:50 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191212100121.29621-1-berto@igalia.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: YOWX_D8xOjmSag0QA5D6xg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/12/19 4:01 AM, Alberto Garcia wrote: > There's a couple of places left in the qcow2 code that still do the > calculation manually, so let's replace them. > > Signed-off-by: Alberto Garcia > --- > block/qcow2.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org