From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Weil" <sw@weilnetz.de>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH-for-10.2? 1/2] tcg/tci: Disable -Wundef FFI_GO_CLOSURES warning
Date: Tue, 2 Dec 2025 16:34:58 -0800 [thread overview]
Message-ID: <87170e51-931b-415f-b79e-949fae0f3216@linaro.org> (raw)
In-Reply-To: <20251202184653.33998-2-philmd@linaro.org>
On 12/2/25 10:46, Philippe Mathieu-Daudé wrote:
> Since we build TCI with FFI (commit 22f15579fa1 "tcg: Build ffi data
> structures for helpers") we get on Darwin:
>
> In file included from ../../tcg/tci.c:22:
> In file included from include/tcg/helper-info.h:13:
> /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/ffi/ffi.h:483:5: warning: 'FFI_GO_CLOSURES' is not defined, evaluates to 0 [-Wundef]
> 483 | #if FFI_GO_CLOSURES
> | ^
> 1 warning generated.
>
> Since this libffi change was committed more than 10 years ago (see
> https://github.com/libffi/libffi/commit/e951d64c0852), just define
> the missing definition on QEMU to silence the warning.
See also c23e9a1c from 2023, which fixed that to use an ifdef.
I suppose the inclusion or exclusion of the go interface is neither here nor there, so
long as it compiles.
r~
next prev parent reply other threads:[~2025-12-03 0:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 18:46 [PATCH-for-10.2 0/2] tcg: Fix TCI build on macOS Philippe Mathieu-Daudé
2025-12-02 18:46 ` [PATCH-for-10.2? 1/2] tcg/tci: Disable -Wundef FFI_GO_CLOSURES warning Philippe Mathieu-Daudé
2025-12-03 0:34 ` Richard Henderson [this message]
2025-12-02 18:46 ` [PATCH-for-10.2 2/2] tcg/tci: Disable Int128 support Philippe Mathieu-Daudé
2025-12-02 22:30 ` Richard Henderson
2025-12-03 13:18 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87170e51-931b-415f-b79e-949fae0f3216@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).