From: Eric Blake <eblake@redhat.com>
To: "Niccolò Belli" <darkbasic@linuxsystems.it>,
"Frediano Ziglio" <fziglio@redhat.com>
Cc: Uri Lublin <uril@redhat.com>,
mst@redhat.com, secalert@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com, spice-devel@lists.freedesktop.org
Subject: Re: [Qemu-devel] [Spice-devel] Always get Invalid password while trying to connect to spice server
Date: Thu, 3 Jan 2019 16:25:00 -0600 [thread overview]
Message-ID: <87174d6c-2437-6331-e44b-93e2ecb8a572@redhat.com> (raw)
In-Reply-To: <04864360-b345-4d49-a842-8cde724b3c94@linuxsystems.it>
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
On 12/27/18 8:51 AM, Niccolò Belli wrote:
> On mercoledì 26 dicembre 2018 13:38:28 CET, Frediano Ziglio wrote:
>> Yes, this looks like a format string error in the upper (not into
>> spice) layer.
>>
>> This potentially is a security problem.
>
> Considering the spice server is exposed to the internet this is
> definitely worth investigating.
>
>> The specific '%' character could be the issue, can you try others
>> ('!', '@' and
>> so on) ?
>
> I tried several other special characters and they all seems to work,
> expect for "Password&&" which gets converted to "Password&&" (if
> I type "Password&&" it works).
Could it be related to this patch where our JSON code mishandles %?
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg00108.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-03 22:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <110999ea-0ab9-49cb-915f-6d08cccdea3c@linuxsystems.it>
[not found] ` <47cfb9f8-5957-7935-063b-304e3c53c268@redhat.com>
[not found] ` <9de9afbe-fc7b-48a0-9b2d-b756f146303d@linuxsystems.it>
2018-12-26 12:38 ` [Qemu-devel] [Spice-devel] Always get Invalid password while trying to connect to spice server Frediano Ziglio
2018-12-27 14:51 ` Niccolò Belli
2019-01-03 22:25 ` Eric Blake [this message]
2019-01-04 10:06 ` Christophe Fergeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87174d6c-2437-6331-e44b-93e2ecb8a572@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=darkbasic@linuxsystems.it \
--cc=fziglio@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=secalert@redhat.com \
--cc=spice-devel@lists.freedesktop.org \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).