From: Fabiano Rosas <farosas@suse.de>
To: Shivang Upadhyay <shivangu@linux.ibm.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Chinmay Rath" <rathc@linux.ibm.com>,
"Doru Blânzeanu" <dblanzeanu@linux.microsoft.com>,
"Magnus Kulke" <magnuskulke@linux.microsoft.com>
Subject: Re: [PATCH] accel: Fix qtest deadlock during unplug
Date: Thu, 24 Sep 2026 12:31:49 -0300 [thread overview]
Message-ID: <871paiacnu.fsf@suse.de> (raw)
In-Reply-To: <59a6c0de163178a7571de6cf8a9530c14fa36c4d.camel@linux.ibm.com>
Shivang Upadhyay <shivangu@linux.ibm.com> writes:
> On Wed, 2026-09-23 at 10:05 -0300, Fabiano Rosas wrote:
>>
>> @Shivang, we're discussing about cpu_remove_sync() down in this
>> thread,
>> maybe that's of interest to you. Philippe is suggesting we could
>> maybe
>> move the call up a layer.
>
> Hi Fabiano,
> I checked the dummp_cpu way to working, I can see you changes makes
> sense here. I couldn't understand much from Philippe's suggestion. Do
> we want to handle the case for thread waiting on sigwait, inside
> cpu_remove_sync ?
>
The point was simply to call cpu_remove_sync() from another spot. I
think he made the same suggestion to you here:
https://lore.kernel.org/r/bb91d62a-f15a-42e5-813d-5ec7e6d92479@oss.qualcomm.com
While researching what would it take to do it, I got concerned about the
effects that setting cpu->unplug could have for targets that currently
do not set it, but nonetheless use it as the cpu loop exit
condition. That question is still open, I haven't got time to look
deeper into it yet.
If you're interested in that area, you could give it a try. As I
mentioned in the other email, the unplug logic was added back then to
improve the usability of spapr cpu hot-unplug so it could be pertinent
to anyone working on ppc.
next prev parent reply other threads:[~2026-09-24 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 14:00 [PATCH] accel: Fix qtest deadlock during unplug Fabiano Rosas
2026-09-21 13:45 ` Philippe Mathieu-Daudé
2026-09-21 21:22 ` Fabiano Rosas
2026-09-23 13:05 ` Fabiano Rosas
2026-09-24 13:16 ` Shivang Upadhyay
2026-09-24 15:31 ` Fabiano Rosas [this message]
2026-11-17 13:09 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871paiacnu.fsf@suse.de \
--to=farosas@suse.de \
--cc=dblanzeanu@linux.microsoft.com \
--cc=magnuskulke@linux.microsoft.com \
--cc=pbonzini@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=rathc@linux.ibm.com \
--cc=richard.henderson@linaro.org \
--cc=shivangu@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox