From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, eesposit@redhat.com,
philmd@linaro.org
Subject: Re: [PATCH v2] kvm: Fix kvm_vm_ioctl() and kvm_device_ioctl() return value
Date: Tue, 02 Dec 2025 09:32:56 +0100 [thread overview]
Message-ID: <871pldxozr.fsf@pond.sub.org> (raw)
In-Reply-To: <20251128152050.3417834-1-armbru@redhat.com> (Markus Armbruster's message of "Fri, 28 Nov 2025 16:20:50 +0100")
Markus Armbruster <armbru@redhat.com> writes:
> These functions wrap ioctl(). When ioctl() fails, it sets @errno.
> The wrappers then return that @errno negated.
>
> Except they call accel_ioctl_end() between calling ioctl() and reading
> @errno. accel_ioctl_end() can clobber @errno, e.g. when a futex()
> system call fails. Seems unlikely, but it's a bug all the same.
>
> Fix by retrieving @errno before calling accel_ioctl_end().
>
> Fixes: a27dd2de68f3 (KVM: keep track of running ioctls)
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Queued for 10.2.
next prev parent reply other threads:[~2025-12-02 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 15:20 [PATCH v2] kvm: Fix kvm_vm_ioctl() and kvm_device_ioctl() return value Markus Armbruster
2025-12-02 8:32 ` Markus Armbruster [this message]
2025-12-02 13:14 ` Michael Tokarev
2025-12-02 13:42 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pldxozr.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eesposit@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).