qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests
@ 2025-02-03 12:43 Thomas Huth
  2025-02-03 15:15 ` Fabiano Rosas
  2025-02-11 16:03 ` Stefano Garzarella
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2025-02-03 12:43 UTC (permalink / raw)
  To: Fabiano Rosas, Laurent Vivier, qemu-devel, Michael S . Tsirkin
  Cc: Paolo Bonzini, Stefano Garzarella, Alex Bennée, Jason Wang,
	Cornelia Huck

All other vhost-user tests here use modern virtio, too, so let's
adjust the vhost-user-net test accordingly.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/vhost-user-test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
index 76d142a158..bd977ef28d 100644
--- a/tests/qtest/vhost-user-test.c
+++ b/tests/qtest/vhost-user-test.c
@@ -1043,7 +1043,8 @@ static void test_multiqueue(void *obj, void *arg, QGuestAllocator *alloc)
 
 static uint64_t vu_net_get_features(TestServer *s)
 {
-    uint64_t features = 0x1ULL << VHOST_F_LOG_ALL |
+    uint64_t features = 0x1ULL << VIRTIO_F_VERSION_1 |
+        0x1ULL << VHOST_F_LOG_ALL |
         0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES;
 
     if (s->queues > 1) {
-- 
2.48.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests
  2025-02-03 12:43 [PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests Thomas Huth
@ 2025-02-03 15:15 ` Fabiano Rosas
  2025-02-11 16:03 ` Stefano Garzarella
  1 sibling, 0 replies; 3+ messages in thread
From: Fabiano Rosas @ 2025-02-03 15:15 UTC (permalink / raw)
  To: Thomas Huth, Laurent Vivier, qemu-devel, Michael S . Tsirkin
  Cc: Paolo Bonzini, Stefano Garzarella, Alex Bennée, Jason Wang,
	Cornelia Huck

Thomas Huth <thuth@redhat.com> writes:

> All other vhost-user tests here use modern virtio, too, so let's
> adjust the vhost-user-net test accordingly.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/qtest/vhost-user-test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
> index 76d142a158..bd977ef28d 100644
> --- a/tests/qtest/vhost-user-test.c
> +++ b/tests/qtest/vhost-user-test.c
> @@ -1043,7 +1043,8 @@ static void test_multiqueue(void *obj, void *arg, QGuestAllocator *alloc)
>  
>  static uint64_t vu_net_get_features(TestServer *s)
>  {
> -    uint64_t features = 0x1ULL << VHOST_F_LOG_ALL |
> +    uint64_t features = 0x1ULL << VIRTIO_F_VERSION_1 |
> +        0x1ULL << VHOST_F_LOG_ALL |
>          0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES;
>  
>      if (s->queues > 1) {

Reviewed-by: Fabiano Rosas <farosas@suse.de>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests
  2025-02-03 12:43 [PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests Thomas Huth
  2025-02-03 15:15 ` Fabiano Rosas
@ 2025-02-11 16:03 ` Stefano Garzarella
  1 sibling, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2025-02-11 16:03 UTC (permalink / raw)
  To: Thomas Huth
  Cc: Fabiano Rosas, Laurent Vivier, qemu-devel, Michael S . Tsirkin,
	Paolo Bonzini, Alex Bennée, Jason Wang, Cornelia Huck

On Mon, Feb 03, 2025 at 01:43:46PM +0100, Thomas Huth wrote:
>All other vhost-user tests here use modern virtio, too, so let's
>adjust the vhost-user-net test accordingly.
>
>Signed-off-by: Thomas Huth <thuth@redhat.com>
>---
> tests/qtest/vhost-user-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
>index 76d142a158..bd977ef28d 100644
>--- a/tests/qtest/vhost-user-test.c
>+++ b/tests/qtest/vhost-user-test.c
>@@ -1043,7 +1043,8 @@ static void test_multiqueue(void *obj, void *arg, QGuestAllocator *alloc)
>
> static uint64_t vu_net_get_features(TestServer *s)
> {
>-    uint64_t features = 0x1ULL << VHOST_F_LOG_ALL |
>+    uint64_t features = 0x1ULL << VIRTIO_F_VERSION_1 |
>+        0x1ULL << VHOST_F_LOG_ALL |
>         0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES;
>
>     if (s->queues > 1) {
>-- 
>2.48.1
>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-11 16:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-03 12:43 [PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests Thomas Huth
2025-02-03 15:15 ` Fabiano Rosas
2025-02-11 16:03 ` Stefano Garzarella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).