From: Fabiano Rosas <farosas@suse.de>
To: Ani Sinha <anisinha@redhat.com>
Cc: Ani Sinha <anisinha@redhat.com>,
kraxel@redhat.com, lvivier@redhat.com, pbonzini@redhat.com,
armbru@redhat.com, philmd@linaro.org, berrange@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH v6 0/3] tests/qtest/libqos: add DMA support for writing and reading fw_cfg files
Date: Mon, 27 Jan 2025 12:29:50 -0300 [thread overview]
Message-ID: <871pwos2a9.fsf@suse.de> (raw)
In-Reply-To: <20250120043847.954881-1-anisinha@redhat.com>
Ani Sinha <anisinha@redhat.com> writes:
> This patchset enables DMA interface support for writing fw-cfg files in
> libqtest. The first patch is just a code refactoring so that fw-cfg
> directory parsing can be part of a separate helper function.
> The second patch is the actual patch that introduces two new apis for
> writing and reading fw-cfg files using DMA interface. The apis are
> tested by writing a new basic qtest for vmcoreinfo device in patch 3.
>
> $ MALLOC_PERTURB_=255 QTEST_QEMU_BINARY=./qemu-system-x86_64 /workspace/qemu-ani/build/tests/qtest/vmcoreinfo-test
> TAP version 13
> # random seed: R02S33ea0ae4568aae69a6191a97e6ea37fc
> 1..1
> # Start of x86_64 tests
> # Start of vmcoreinfo tests
> # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-267380.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-267380.qmp,id=char0 -mon chardev=char0,mode=control -display none -audio none -device vmcoreinfo -accel qtest
> ok 1 /x86_64/vmcoreinfo/basic-write
> # End of vmcoreinfo tests
> # End of x86_64 tests
>
> CI pipeline is green with this patch series: https://gitlab.com/anisinha/qemu/-/pipelines/1629670893
>
> checkpatch is clean:
>
> $ ./scripts/checkpatch.pl patches-v6/*
> Checking patches-v6/v6-0000-cover-letter.patch...
> total: 0 errors, 0 warnings, 0 lines checked
>
> patches-v6/v6-0000-cover-letter.patch has no obvious style problems and is ready for submission.
> Checking patches-v6/v6-0001-libqos-fw_cfg-refactor-file-directory-iteraton-to.patch...
> total: 0 errors, 0 warnings, 80 lines checked
>
> patches-v6/v6-0001-libqos-fw_cfg-refactor-file-directory-iteraton-to.patch has no obvious style problems and is ready for submission.
> Checking patches-v6/v6-0002-tests-qtest-libqos-add-DMA-support-for-writing-an.patch...
> total: 0 errors, 0 warnings, 175 lines checked
>
> patches-v6/v6-0002-tests-qtest-libqos-add-DMA-support-for-writing-an.patch has no obvious style problems and is ready for submission.
> Checking patches-v6/v6-0003-tests-qtest-vmcoreinfo-add-a-unit-test-to-exerciz.patch...
> total: 0 errors, 0 warnings, 111 lines checked
>
> patches-v6/v6-0003-tests-qtest-vmcoreinfo-add-a-unit-test-to-exerciz.patch has no obvious style problems and is ready for submission.
>
>
> cc: kraxel@redhat.com
> cc: farosas@suse.de
> cc: lvivier@redhat.com
> cc: pbonzini@redhat.com
> cc: armbru@redhat.com
> cc: philmd@linaro.org
> cc: berrange@redhat.com
> cc: qemu-devel@nongnu.org
> cc: farosas@suse.de
I'll give it the rest of the week and take this series via qtest-next
unless there's objections.
prev parent reply other threads:[~2025-01-27 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 4:38 [PATCH v6 0/3] tests/qtest/libqos: add DMA support for writing and reading fw_cfg files Ani Sinha
2025-01-20 4:38 ` [PATCH v6 1/3] libqos/fw_cfg: refactor file directory iteraton to make it more reusable Ani Sinha
2025-01-20 4:38 ` [PATCH v6 2/3] tests/qtest/libqos: add DMA support for writing and reading fw_cfg files Ani Sinha
2025-01-27 7:12 ` Ani Sinha
2025-01-27 15:28 ` Fabiano Rosas
2025-01-20 4:38 ` [PATCH v6 3/3] tests/qtest/vmcoreinfo: add a unit test to exercize basic vmcoreinfo function Ani Sinha
2025-01-27 7:12 ` Ani Sinha
2025-01-27 15:28 ` Fabiano Rosas
2025-01-27 15:29 ` Fabiano Rosas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pwos2a9.fsf@suse.de \
--to=farosas@suse.de \
--cc=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).