* [PATCH] hw/audio/virtio-snd-pci: fix the PCI class code
@ 2023-11-07 18:50 Volker Rümelin
2023-11-07 18:57 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Volker Rümelin @ 2023-11-07 18:50 UTC (permalink / raw)
To: Gerd Hoffmann, Michael S. Tsirkin, Manos Pitsidianakis
Cc: qemu-devel, Alex Bennée
The virtio sound device is currently an unclassified PCI device.
~> sudo lspci -s '00:02.0' -v -nn | head -n 2
00:02.0 Unclassified device [00ff]:
Red Hat, Inc. Device [1af4:1059] (rev 01)
Subsystem: Red Hat, Inc. Device [1af4:1100]
Set the correct PCI class code to change the device to a
multimedia audio controller.
~> sudo lspci -s '00:02.0' -v -nn | head -n 2
00:02.0 Multimedia audio controller [0401]:
Red Hat, Inc. Device [1af4:1059] (rev 01)
Subsystem: Red Hat, Inc. Device [1af4:1100]
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
The two additional lines have been lost between v6 and v7 of
the "Add VIRTIO sound card" patch series.
hw/audio/virtio-snd-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/audio/virtio-snd-pci.c b/hw/audio/virtio-snd-pci.c
index 0f92e0752b..ab58c6410e 100644
--- a/hw/audio/virtio-snd-pci.c
+++ b/hw/audio/virtio-snd-pci.c
@@ -47,12 +47,14 @@ static void virtio_snd_pci_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
VirtioPCIClass *vpciklass = VIRTIO_PCI_CLASS(klass);
+ PCIDeviceClass *pcidevklass = PCI_DEVICE_CLASS(klass);
device_class_set_props(dc, virtio_snd_pci_properties);
dc->desc = "Virtio Sound";
set_bit(DEVICE_CATEGORY_SOUND, dc->categories);
vpciklass->realize = virtio_snd_pci_realize;
+ pcidevklass->class_id = PCI_CLASS_MULTIMEDIA_AUDIO;
}
static void virtio_snd_pci_instance_init(Object *obj)
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hw/audio/virtio-snd-pci: fix the PCI class code
2023-11-07 18:50 [PATCH] hw/audio/virtio-snd-pci: fix the PCI class code Volker Rümelin
@ 2023-11-07 18:57 ` Philippe Mathieu-Daudé
2023-11-07 19:08 ` Manos Pitsidianakis
2023-11-07 19:33 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-11-07 18:57 UTC (permalink / raw)
To: Volker Rümelin, Gerd Hoffmann, Michael S. Tsirkin,
Manos Pitsidianakis
Cc: qemu-devel, Alex Bennée
On 7/11/23 19:50, Volker Rümelin wrote:
> The virtio sound device is currently an unclassified PCI device.
>
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Unclassified device [00ff]:
> Red Hat, Inc. Device [1af4:1059] (rev 01)
> Subsystem: Red Hat, Inc. Device [1af4:1100]
>
> Set the correct PCI class code to change the device to a
> multimedia audio controller.
>
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Multimedia audio controller [0401]:
> Red Hat, Inc. Device [1af4:1059] (rev 01)
> Subsystem: Red Hat, Inc. Device [1af4:1100]
>
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
> The two additional lines have been lost between v6 and v7 of
> the "Add VIRTIO sound card" patch series.
>
> hw/audio/virtio-snd-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/audio/virtio-snd-pci: fix the PCI class code
2023-11-07 18:50 [PATCH] hw/audio/virtio-snd-pci: fix the PCI class code Volker Rümelin
2023-11-07 18:57 ` Philippe Mathieu-Daudé
@ 2023-11-07 19:08 ` Manos Pitsidianakis
2023-11-07 19:33 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Manos Pitsidianakis @ 2023-11-07 19:08 UTC (permalink / raw)
To: Volker Rümelin
Cc: Gerd Hoffmann, Michael S. Tsirkin, qemu-devel, Alex Bennée
On Tue, 7 Nov 2023 at 20:50, Volker Rümelin <vr_qemu@t-online.de> wrote:
>
> The virtio sound device is currently an unclassified PCI device.
>
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Unclassified device [00ff]:
> Red Hat, Inc. Device [1af4:1059] (rev 01)
> Subsystem: Red Hat, Inc. Device [1af4:1100]
>
> Set the correct PCI class code to change the device to a
> multimedia audio controller.
>
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Multimedia audio controller [0401]:
> Red Hat, Inc. Device [1af4:1059] (rev 01)
> Subsystem: Red Hat, Inc. Device [1af4:1100]
>
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/audio/virtio-snd-pci: fix the PCI class code
2023-11-07 18:50 [PATCH] hw/audio/virtio-snd-pci: fix the PCI class code Volker Rümelin
2023-11-07 18:57 ` Philippe Mathieu-Daudé
2023-11-07 19:08 ` Manos Pitsidianakis
@ 2023-11-07 19:33 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2023-11-07 19:33 UTC (permalink / raw)
To: Volker Rümelin
Cc: Gerd Hoffmann, Michael S. Tsirkin, Manos Pitsidianakis,
qemu-devel
Volker Rümelin <vr_qemu@t-online.de> writes:
> The virtio sound device is currently an unclassified PCI device.
>
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Unclassified device [00ff]:
> Red Hat, Inc. Device [1af4:1059] (rev 01)
> Subsystem: Red Hat, Inc. Device [1af4:1100]
>
> Set the correct PCI class code to change the device to a
> multimedia audio controller.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-07 19:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-07 18:50 [PATCH] hw/audio/virtio-snd-pci: fix the PCI class code Volker Rümelin
2023-11-07 18:57 ` Philippe Mathieu-Daudé
2023-11-07 19:08 ` Manos Pitsidianakis
2023-11-07 19:33 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).