From: Juan Quintela <quintela@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-s390x@nongnu.org, "Peter Xu" <peterx@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH] tests/avocado/migration: Remove the malfunctioning s390x tests
Date: Mon, 24 Jul 2023 11:03:12 +0200 [thread overview]
Message-ID: <871qgxheb3.fsf@secure.mitica> (raw)
In-Reply-To: <20230721164346.10112-1-thuth@redhat.com> (Thomas Huth's message of "Fri, 21 Jul 2023 18:43:46 +0200")
Thomas Huth <thuth@redhat.com> wrote:
> The tests from tests/avocado/migration.py do not work at all
> on s390x - the bios shuts down immediately when it cannot find
> a boot disk, so there is nothing left to migrate here. For doing
> a proper migration test, we would need a proper payload, but we
> already do such tests in the migration *qtest*, so it is unnecessary
> to redo such a test here, thus let's simply remove this test.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
> ---
> I'm tempted to remove this file completely - what test coverage do
> we get here that we don't get by tests/qtest/migration-test.c already?
Nothing new there, just three small tests. That are included in
migration-test.c
I agree we can drop it if we want to.
Later, Juan.
prev parent reply other threads:[~2023-07-24 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 16:43 [PATCH] tests/avocado/migration: Remove the malfunctioning s390x tests Thomas Huth
2023-07-24 9:03 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qgxheb3.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).