qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hw: arm: allwinner-sramc: Set class_size
@ 2023-06-28 11:09 Akihiko Odaki
  2023-06-28 11:16 ` Philippe Mathieu-Daudé
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Akihiko Odaki @ 2023-06-28 11:09 UTC (permalink / raw)
  Cc: qemu-devel, qemu-arm, Strahinja Jankovic, Peter Maydell,
	Beniamino Galvani, Akihiko Odaki

AwSRAMCClass is larger than SysBusDeviceClass so the class size must be
advertised accordingly.

Fixes: 05def917e1 ("hw: arm: allwinner-sramc: Add SRAM Controller support for R40")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 hw/misc/allwinner-sramc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/misc/allwinner-sramc.c b/hw/misc/allwinner-sramc.c
index a8b731f8f2..d76c24d081 100644
--- a/hw/misc/allwinner-sramc.c
+++ b/hw/misc/allwinner-sramc.c
@@ -159,6 +159,7 @@ static const TypeInfo allwinner_sramc_info = {
     .parent        = TYPE_SYS_BUS_DEVICE,
     .instance_init = allwinner_sramc_init,
     .instance_size = sizeof(AwSRAMCState),
+    .class_size    = sizeof(AwSRAMCClass),
     .class_init    = allwinner_sramc_class_init,
 };
 
-- 
2.41.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] hw: arm: allwinner-sramc: Set class_size
  2023-06-28 11:09 [PATCH] hw: arm: allwinner-sramc: Set class_size Akihiko Odaki
@ 2023-06-28 11:16 ` Philippe Mathieu-Daudé
  2023-06-28 14:09 ` Richard Henderson
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-06-28 11:16 UTC (permalink / raw)
  To: Akihiko Odaki
  Cc: qemu-devel, qemu-arm, Strahinja Jankovic, Peter Maydell,
	Beniamino Galvani

On 28/6/23 13:09, Akihiko Odaki wrote:
> AwSRAMCClass is larger than SysBusDeviceClass so the class size must be
> advertised accordingly.
> 
> Fixes: 05def917e1 ("hw: arm: allwinner-sramc: Add SRAM Controller support for R40")
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   hw/misc/allwinner-sramc.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] hw: arm: allwinner-sramc: Set class_size
  2023-06-28 11:09 [PATCH] hw: arm: allwinner-sramc: Set class_size Akihiko Odaki
  2023-06-28 11:16 ` Philippe Mathieu-Daudé
@ 2023-06-28 14:09 ` Richard Henderson
  2023-07-04 13:22 ` Peter Maydell
  2023-07-04 13:43 ` Alex Bennée
  3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2023-06-28 14:09 UTC (permalink / raw)
  To: Akihiko Odaki
  Cc: qemu-devel, qemu-arm, Strahinja Jankovic, Peter Maydell,
	Beniamino Galvani

On 6/28/23 13:09, Akihiko Odaki wrote:
> AwSRAMCClass is larger than SysBusDeviceClass so the class size must be
> advertised accordingly.
> 
> Fixes: 05def917e1 ("hw: arm: allwinner-sramc: Add SRAM Controller support for R40")
> Signed-off-by: Akihiko Odaki<akihiko.odaki@daynix.com>
> ---
>   hw/misc/allwinner-sramc.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] hw: arm: allwinner-sramc: Set class_size
  2023-06-28 11:09 [PATCH] hw: arm: allwinner-sramc: Set class_size Akihiko Odaki
  2023-06-28 11:16 ` Philippe Mathieu-Daudé
  2023-06-28 14:09 ` Richard Henderson
@ 2023-07-04 13:22 ` Peter Maydell
  2023-07-04 13:43 ` Alex Bennée
  3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2023-07-04 13:22 UTC (permalink / raw)
  To: Akihiko Odaki; +Cc: qemu-devel, qemu-arm, Strahinja Jankovic, Beniamino Galvani

On Wed, 28 Jun 2023 at 12:09, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> AwSRAMCClass is larger than SysBusDeviceClass so the class size must be
> advertised accordingly.
>
> Fixes: 05def917e1 ("hw: arm: allwinner-sramc: Add SRAM Controller support for R40")
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> --



Applied to target-arm.next, thanks.

-- PMM


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] hw: arm: allwinner-sramc: Set class_size
  2023-06-28 11:09 [PATCH] hw: arm: allwinner-sramc: Set class_size Akihiko Odaki
                   ` (2 preceding siblings ...)
  2023-07-04 13:22 ` Peter Maydell
@ 2023-07-04 13:43 ` Alex Bennée
  3 siblings, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2023-07-04 13:43 UTC (permalink / raw)
  To: Akihiko Odaki
  Cc: qemu-devel, Strahinja Jankovic, Peter Maydell, Beniamino Galvani,
	qemu-arm


Akihiko Odaki <akihiko.odaki@daynix.com> writes:

> AwSRAMCClass is larger than SysBusDeviceClass so the class size must be
> advertised accordingly.
>
> Fixes: 05def917e1 ("hw: arm: allwinner-sramc: Add SRAM Controller support for R40")
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-07-04 13:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-28 11:09 [PATCH] hw: arm: allwinner-sramc: Set class_size Akihiko Odaki
2023-06-28 11:16 ` Philippe Mathieu-Daudé
2023-06-28 14:09 ` Richard Henderson
2023-07-04 13:22 ` Peter Maydell
2023-07-04 13:43 ` Alex Bennée

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).