From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DEEAC64ED6 for ; Mon, 27 Feb 2023 15:12:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWfB9-0002gU-M5; Mon, 27 Feb 2023 10:12:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWfB1-0002cK-4C for qemu-devel@nongnu.org; Mon, 27 Feb 2023 10:12:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWfAz-00062n-H9 for qemu-devel@nongnu.org; Mon, 27 Feb 2023 10:12:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677510749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1N24a9jHrr8aJ2RFQYYJuZ0zIDzBlJZkBj9a2PQXJok=; b=aMSGyuUYbpgMHCVbzOC3VRuqqsPJQwaC14o/+HKkPJytGkPJ7YZwm0egRgz9fCRKxLwdxd WjscNs/eG+IXxmwgUC0o2GAA9vGx17l/uOU+T0yi+U8BHMFp+Sc/Ibs3wwjLnKAgkGGH/x 4peZQPzgXt8ANPCftQ8bj2DMAW5i/OA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-376-qaFv04jzNlem9IXZUjZ_uQ-1; Mon, 27 Feb 2023 10:12:24 -0500 X-MC-Unique: qaFv04jzNlem9IXZUjZ_uQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3123188646A; Mon, 27 Feb 2023 15:12:24 +0000 (UTC) Received: from localhost (unknown [10.45.226.217]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE3DA40C6EC4; Mon, 27 Feb 2023 15:12:23 +0000 (UTC) From: Cornelia Huck To: Eric Auger , Richard Henderson , Peter Maydell , Thomas Huth , Laurent Vivier Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, "Dr. David Alan Gilbert" , Juan Quintela , Gavin Shan , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v5 2/3] arm/kvm: add support for MTE In-Reply-To: <877cwun51m.fsf@redhat.com> Organization: Red Hat GmbH References: <20230203134433.31513-1-cohuck@redhat.com> <20230203134433.31513-3-cohuck@redhat.com> <071ec3a6-cb4b-0dac-87fd-f3c3d00b5e83@redhat.com> <877cwun51m.fsf@redhat.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Mon, 27 Feb 2023 16:12:22 +0100 Message-ID: <871qmb5ei1.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Feb 06 2023, Cornelia Huck wrote: > On Mon, Feb 06 2023, Eric Auger wrote: > >> Hi, >> >> On 2/3/23 21:40, Richard Henderson wrote: >>> On 2/3/23 03:44, Cornelia Huck wrote: >>>> +static void aarch64_cpu_get_mte(Object *obj, Visitor *v, const char >>>> *name, >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 void *opaque, Error **errp) >>>> +{ >>>> +=C2=A0=C2=A0=C2=A0 ARMCPU *cpu =3D ARM_CPU(obj); >>>> +=C2=A0=C2=A0=C2=A0 OnOffAuto mte =3D cpu->prop_mte; >>>> + >>>> +=C2=A0=C2=A0=C2=A0 visit_type_OnOffAuto(v, name, &mte, errp); >>>> +} >>>=20 >>> You don't need to copy to a local variable here. >>>=20 >>>> + >>>> +static void aarch64_cpu_set_mte(Object *obj, Visitor *v, const char >>>> *name, >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 void *opaque, Error **errp) >>>> +{ >>>> +=C2=A0=C2=A0=C2=A0 ARMCPU *cpu =3D ARM_CPU(obj); >>>> + >>>> +=C2=A0=C2=A0=C2=A0 visit_type_OnOffAuto(v, name, &cpu->prop_mte, errp= ); >>>> +} >>>=20 >>> ... which makes get and set functions identical. >>> No need for both. >> This looks like a common pattern though. virt_get_acpi/set_acpi in >> virt.c or pc_machine_get_vmport/set_vmport in i386/pc.c and many other >> places (microvm ...). Do those other callers also need some simplificati= ons? > > Indeed, I'm pretty sure that I copied + adapted it from somewhere :) > > Should we clean up all instances in one go instead? (Probably on top of > this series, in order to minimize conflicts with other changes.) Any objections to going with the code above and just doing a general cleanup on top?