qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@linux.ibm.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: clg@kaod.org, danielhb413@gmail.com, qemu-ppc@nongnu.org,
	qemu-devel@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH 03/17] target/ppc: Move 40x CPUs code to their own file
Date: Wed, 02 Mar 2022 10:37:31 -0300	[thread overview]
Message-ID: <871qzkqxus.fsf@linux.ibm.com> (raw)
In-Reply-To: <941e7add-aa94-d6d8-11dc-6eb8dffc3c@eik.bme.hu>

BALATON Zoltan <balaton@eik.bme.hu> writes:

> On Tue, 1 Mar 2022, Fabiano Rosas wrote:
>> Affects the 405 CPU.
>>
>> This moves init_proc, init_excp and register_*sprs functions that are
>> related to the 40x CPUs (currently only 405) into a separate file.
>>
>> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
>> ---
>> target/ppc/cpu_40x.c   | 263 +++++++++++++++++++++++++++++++++++++++++
>> target/ppc/cpu_init.c  | 250 ---------------------------------------
>> target/ppc/meson.build |   1 +
>> 3 files changed, 264 insertions(+), 250 deletions(-)
>> create mode 100644 target/ppc/cpu_40x.c
>>
>> diff --git a/target/ppc/cpu_40x.c b/target/ppc/cpu_40x.c
>> new file mode 100644
>> index 0000000000..4ed2cbc305
>> --- /dev/null
>> +++ b/target/ppc/cpu_40x.c
>> @@ -0,0 +1,263 @@
>> +/*
>> + * CPU initialization for PowerPC 40x CPUs
>> + *
>> + *  Copyright IBM Corp. 2022
>
> I think you can't replace the copyright when moving code. You have to 
> retain the original header and maybe you can add your own if you change or 
> rewrite it. You can only drop old copyright it you've completely replaced 
> the content.

Well spotted, thanks!



  reply	other threads:[~2022-03-02 13:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 13:56 [PATCH 00/17] target/ppc: CPU families split Fabiano Rosas
2022-03-01 13:56 ` [PATCH 01/17] target/ppc: Add a tracepoint for System Calls Fabiano Rosas
2022-03-01 13:56 ` [PATCH 02/17] target/ppc: Use trace-events instead of CPU_LOG_INT Fabiano Rosas
2022-03-01 13:56 ` [PATCH 03/17] target/ppc: Move 40x CPUs code to their own file Fabiano Rosas
2022-03-01 22:36   ` BALATON Zoltan
2022-03-02 13:37     ` Fabiano Rosas [this message]
2022-03-01 13:56 ` [PATCH 04/17] target/ppc: Move 6xx " Fabiano Rosas
2022-03-01 13:56 ` [PATCH 05/17] target/ppc: Move 7xx " Fabiano Rosas
2022-03-01 13:56 ` [PATCH 06/17] target/ppc: Move 74xx " Fabiano Rosas
2022-03-01 13:56 ` [PATCH 07/17] target/ppc: Move BookE " Fabiano Rosas
2022-03-01 13:56 ` [PATCH 08/17] target/ppc: Move BookS CPUs " Fabiano Rosas
2022-03-01 13:56 ` [PATCH 09/17] target/ppc: Remove leftover comments from cpu_init Fabiano Rosas
2022-03-01 13:56 ` [PATCH 10/17] target/ppc: Expose some excp_helper functions Fabiano Rosas
2022-03-01 13:56 ` [PATCH 11/17] target/ppc: Move powerpc_excp_40x into cpu_40x.c Fabiano Rosas
2022-03-01 13:56 ` [PATCH 12/17] target/ppc: Move powerpc_excp_6xx into cpu_6xx.c Fabiano Rosas
2022-03-01 13:56 ` [PATCH 13/17] target/ppc: Move powerpc_excp_7xx into cpu_7xx.c Fabiano Rosas
2022-03-01 13:56 ` [PATCH 14/17] target/ppc: Move powerpc_excp_74xx into cpu_74xx.c Fabiano Rosas
2022-03-01 13:56 ` [PATCH 15/17] target/ppc: Move powerpc_excp_booke into cpu_booke.c Fabiano Rosas
2022-03-01 13:56 ` [PATCH 16/17] target/ppc: Move powerpc_excp_books into cpu_books.c Fabiano Rosas
2022-03-01 13:56 ` [PATCH 17/17] target/ppc: Move powerpc_excp* to the PowerPCCPU Class Fabiano Rosas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qzkqxus.fsf@linux.ibm.com \
    --to=farosas@linux.ibm.com \
    --cc=balaton@eik.bme.hu \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).