qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Fam Zheng" <fam@euphon.net>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 2/4] scripts/qemugdb: Remove shebang header
Date: Tue, 21 Apr 2020 11:43:43 +0100	[thread overview]
Message-ID: <871rohdsps.fsf@linaro.org> (raw)
In-Reply-To: <20200421094216.24927-3-f4bug@amsat.org>


Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> These scripts are loaded as plugin by GDB (and they don't
> have any __main__ entry point). Remove the shebang header.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Acked-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  scripts/qemugdb/__init__.py  | 3 +--
>  scripts/qemugdb/aio.py       | 3 +--
>  scripts/qemugdb/coroutine.py | 3 +--
>  scripts/qemugdb/mtree.py     | 4 +---
>  scripts/qemugdb/tcg.py       | 1 -
>  5 files changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/scripts/qemugdb/__init__.py b/scripts/qemugdb/__init__.py
> index 969f552b26..da8ff612e5 100644
> --- a/scripts/qemugdb/__init__.py
> +++ b/scripts/qemugdb/__init__.py
> @@ -1,5 +1,4 @@
> -#!/usr/bin/python
> -
> +#
>  # GDB debugging support
>  #
>  # Copyright (c) 2015 Linaro Ltd
> diff --git a/scripts/qemugdb/aio.py b/scripts/qemugdb/aio.py
> index 2ba00c4444..d7c1ba0c28 100644
> --- a/scripts/qemugdb/aio.py
> +++ b/scripts/qemugdb/aio.py
> @@ -1,5 +1,4 @@
> -#!/usr/bin/python
> -
> +#
>  # GDB debugging support: aio/iohandler debug
>  #
>  # Copyright (c) 2015 Red Hat, Inc.
> diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py
> index 41e079d0e2..db61389022 100644
> --- a/scripts/qemugdb/coroutine.py
> +++ b/scripts/qemugdb/coroutine.py
> @@ -1,5 +1,4 @@
> -#!/usr/bin/python
> -
> +#
>  # GDB debugging support
>  #
>  # Copyright 2012 Red Hat, Inc. and/or its affiliates
> diff --git a/scripts/qemugdb/mtree.py b/scripts/qemugdb/mtree.py
> index 3030a60d3f..8fe42c3c12 100644
> --- a/scripts/qemugdb/mtree.py
> +++ b/scripts/qemugdb/mtree.py
> @@ -1,5 +1,4 @@
> -#!/usr/bin/python
> -
> +#
>  # GDB debugging support
>  #
>  # Copyright 2012 Red Hat, Inc. and/or its affiliates
> @@ -84,4 +83,3 @@ def print_item(self, ptr, offset = gdb.Value(0), level = 0):
>          while not isnull(subregion):
>              self.print_item(subregion, addr, level)
>              subregion = subregion['subregions_link']['tqe_next']
> -
> diff --git a/scripts/qemugdb/tcg.py b/scripts/qemugdb/tcg.py
> index 18880fc9a7..16c03c06a9 100644
> --- a/scripts/qemugdb/tcg.py
> +++ b/scripts/qemugdb/tcg.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/python
>  # -*- coding: utf-8 -*-
>  #
>  # GDB debugging support, TCG status


-- 
Alex Bennée


  reply	other threads:[~2020-04-21 10:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21  9:42 [PATCH 0/4] scripts: More Python fixes Philippe Mathieu-Daudé
2020-04-21  9:42 ` [PATCH 1/4] MAINTAINERS: Cover the GDB Python scripts in the gdbstub section Philippe Mathieu-Daudé
2020-04-21 10:43   ` Alex Bennée
2020-04-21  9:42 ` [PATCH 2/4] scripts/qemugdb: Remove shebang header Philippe Mathieu-Daudé
2020-04-21 10:43   ` Alex Bennée [this message]
2020-04-21  9:42 ` [PATCH 3/4] scripts/qmp: Use Python 3 interpreter Philippe Mathieu-Daudé
2020-04-29 13:49   ` John Snow
2020-04-21  9:42 ` [PATCH 4/4] scripts/qmp: Fix QEMU Python scripts path Philippe Mathieu-Daudé
2020-04-29 13:54   ` John Snow
2020-04-30  5:04     ` Markus Armbruster
2020-04-30 17:56       ` John Snow
2020-05-02  5:54         ` Markus Armbruster
2020-05-04 18:24           ` John Snow
2020-05-13 21:10       ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rohdsps.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).