qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Aleksandar Markovic <amarkovic@wavecomp.com>
Subject: Re: [Qemu-devel] [BUG] gcov support appears to be broken
Date: Mon, 05 Aug 2019 15:11:15 +0100	[thread overview]
Message-ID: <871rxzk8ho.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA8NE=hy4a-WuDuKeysi3KOjy8=ybHbLKkvzPM=ELvXBnQ@mail.gmail.com>


Peter Maydell <peter.maydell@linaro.org> writes:

> On Mon, 5 Aug 2019 at 11:39, Aleksandar Markovic <amarkovic@wavecomp.com> wrote:
>>
>> Hello, according to out docs, here is the procedure that should produce coverage report for execution of the complete "make check":
>>
>> #./configure --enable-gcov
>> #make
>> #make check
>> #make coverage-report
>>
>> It seems that first three commands execute as expected. (For example,
>> there are plenty of files generated by "make check" that would've not
>> been generated if "enable-gcov" hadn't been chosen.) However, the
>> last command complains about some missing files related to FP
>> support. If those files are added (for example, artificially, using
>> "touch <missing-file"), that it starts complaining about missing some
>> decodetree-generated files. Other kinds of files are involved too.

The gcov tool is fairly noisy about missing files but that just
indicates the tests haven't exercised those code paths. "make check"
especially doesn't touch much of the TCG code and a chunk of floating
point.

>>
>> It would be nice to have coverage support working. Please somebody
>> take a look, or explain if I make a mistake or misunderstood our gcov
>> support.

So your failure mode is no report is generated at all? It's working for
me here.

>
> Cc'ing Alex who's probably the closest we have to a gcov expert.
>
> (make/make check of a --enable-gcov build is in the set of things our
> Travis CI setup runs, so we do defend that part against regressions.)

We defend the build but I have just checked and it seems our
check_coverage script is currently failing:

  https://travis-ci.org/stsquad/qemu/jobs/567809808#L10328

But as it's an after_success script it doesn't fail the build.

>
> thanks
> -- PMM


--
Alex Bennée


  reply	other threads:[~2019-08-05 14:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-05 10:39 [Qemu-devel] [BUG] gcov support appears to be broken Aleksandar Markovic
2019-08-05 11:02 ` Peter Maydell
2019-08-05 14:11   ` Alex Bennée [this message]
2019-08-05 15:36     ` Aleksandar Markovic
2019-08-05 15:39       ` Aleksandar Markovic
2019-08-05 18:56         ` [Qemu-devel] [BUG] gcov support appears to be broken - solved? Aleksandar Markovic
2019-08-05 19:17           ` Alex Bennée
2019-08-05 19:31             ` Aleksandar Markovic
2019-08-05 19:58             ` [Qemu-devel] ]Re: " Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rxzk8ho.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=amarkovic@wavecomp.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).