From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, cota@braap.org
Subject: Re: [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division
Date: Thu, 04 Oct 2018 10:13:55 +0100 [thread overview]
Message-ID: <871s96rs4s.fsf@linaro.org> (raw)
In-Reply-To: <20181003180711.19335-1-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> Changes from v1:
> * Preserve udiv_qrnnd as a separate division primitive that
> could be used as a building block for float128 division.
> * Include asm fragments for x86_64, s390x, and ppc64.
It passes my fops fdiv_double test but Emilio's test is reporting:
Errors found in f64_div, rounding near_even:
+252.7FFFFFFFFFF80 +001.FFFFFFFFFFFFE
=> +64F.7FFFFFFFFFF82 ....x expected +64F.7FFFFFFFFFF81 ....x
+000.FFFFFFFFFFFFF +3FE.FFFFFFFFFFFFF
=> +001.0000000000000 ...ux expected +000.FFFFFFFFFFFFF ...ux
+000.FFFFFFFFFFFFF -3FE.FFFFFFFFFFFFF
=> -001.0000000000000 ...ux expected -000.FFFFFFFFFFFFF ...ux
+000.FFFFFFFFFFFFE +3FE.FFFFFFFFFFFFF
=> +000.FFFFFFFFFFFFF ...ux expected +000.FFFFFFFFFFFFE ...ux
+000.FFFFFFFFFFFFE +3FF.FFFFFFFFFFFFE
=> +000.8000000000000 ...ux expected +000.7FFFFFFFFFFFF ...ux
+000.FFFFFFFFFFFFE -3FE.FFFFFFFFFFFFF
=> -000.FFFFFFFFFFFFF ...ux expected -000.FFFFFFFFFFFFE ...ux
+000.FFFFFFFFFFFFE -3FF.FFFFFFFFFFFFE
=> -000.8000000000000 ...ux expected -000.7FFFFFFFFFFFF ...ux
-401.E7D66F623CB4C +787.FEFF7FFFFFFFE
=> -078.E8CB4F3CAEDB8 ....x expected -078.E8CB4F3CAEDB7 ....x
+3FC.0000000007FEF +198.0000002000007
=> +662.FFFFFFC00FFD1 ....x expected +662.FFFFFFC00FFD0 ....x
-400.FFFFF8000001F -41C.FFFFFFBFFFFDF
=> +3E2.FFFFF84000031 ....x expected +3E2.FFFFF84000030 ....x
-7FE.7FFFFFFFBFFFF +3FE.FFFFFFFFFFFFE
=> -7FE.7FFFFFFFC0001 ....x expected -7FE.7FFFFFFFC0000 ....x
+001.FFFFFFFFFFFFE +3FF.FFFFFFFFFFFFF
=> +001.0000000000000 ...ux expected +000.FFFFFFFFFFFFF ...ux
+001.FFFFFFFFFFFFE -3FF.FFFFFFFFFFFFF
=> -001.0000000000000 ...ux expected -000.FFFFFFFFFFFFF ...ux
+3CA.0000000000000 +4CF.FFFFFE000001F
=> +2F9.0000010000001 ....x expected +2F9.0000010000000 ....x
+3FD.0000000000000 -400.000003DFFFFFF
=> -3FB.FFFFF840001E3 ....x expected -3FB.FFFFF840001E2 ....x
+2C6.00000000003EF -400.0000400400000
=> -2C4.FFFF7FF82081E ....x expected -2C4.FFFF7FF82081D ....x
+3FD.0000000000001 -3CA.FFFFFF0001FFF
=> -431.0000007FFF006 ....x expected -431.0000007FFF005 ....x
-002.FFFFFFFFFFFDE -400.FFFFFFFFFFFFF
=> +000.FFFFFFFFFFFF0 ...ux expected +000.FFFFFFFFFFFEF ...ux
+3FE.0000000000001 -3FF.0000001FFFFFF
=> -3FD.FFFFFFC000005 ....x expected -3FD.FFFFFFC000004 ....x
+3FF.0000000000000 -47E.FFFFFC00000FF
=> -37F.000001FFFFFC1 ....x expected -37F.000001FFFFFC0 ....x
>
> r~
>
>
> Richard Henderson (4):
> softfloat: Fix division
> softfloat: Specialize udiv_qrnnd for x86_64
> softfloat: Specialize udiv_qrnnd for s390x
> softfloat: Specialize udiv_qrnnd for ppc64
>
> include/fpu/softfloat-macros.h | 35 +++++++++++++++++++++++++++++++---
> fpu/softfloat.c | 35 ++++++++++++++++++++++++++--------
> 2 files changed, 59 insertions(+), 11 deletions(-)
--
Alex Bennée
next prev parent reply other threads:[~2018-10-04 9:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 18:07 [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division Richard Henderson
2018-10-03 18:07 ` [Qemu-devel] [PATCH v2 1/4] " Richard Henderson
2018-10-03 18:07 ` [Qemu-devel] [PATCH v2 2/4] softfloat: Specialize udiv_qrnnd for x86_64 Richard Henderson
2018-10-03 18:07 ` [Qemu-devel] [PATCH v2 3/4] softfloat: Specialize udiv_qrnnd for s390x Richard Henderson
2018-10-05 9:56 ` David Hildenbrand
2018-10-03 18:07 ` [Qemu-devel] [PATCH v2 4/4] softfloat: Specialize udiv_qrnnd for ppc64 Richard Henderson
2018-10-04 0:18 ` David Gibson
2018-10-04 9:13 ` Alex Bennée [this message]
2018-10-04 14:55 ` [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division Emilio G. Cota
2018-10-04 15:43 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s96rs4s.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).