From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcQky-0004xD-0r for qemu-devel@nongnu.org; Tue, 01 Aug 2017 02:34:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcQkx-0004jp-70 for qemu-devel@nongnu.org; Tue, 01 Aug 2017 02:34:16 -0400 From: Markus Armbruster References: Date: Tue, 01 Aug 2017 08:34:01 +0200 In-Reply-To: (Jeff Cody's message of "Mon, 31 Jul 2017 09:47:25 -0400") Message-ID: <871sovztie.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 for-2.11 3/3] qemu-iotests: add option to save temp files on error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: qemu-devel@nongnu.org, kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, jsnow@redhat.com Jeff Cody writes: > Now that ./check takes care of cleaning up after each tests, it > can also selectively not clean up. Add option to leave all output from > tests intact if that test encountered an error. > > Note: this currently only works for bash tests, as the python tests > still clean up after themselves manually. Should we add a TODO comment for that? Much appreciated work, by the way. You might want to mention in one of your commit messages that this is also a step towards running iotests in parallel. Another step towards sanity would be making $TEST_DIR instead of $source_iotests the current working directory for running tests.