From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLC72-0008My-Vy for qemu-devel@nongnu.org; Wed, 14 Jun 2017 13:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLC6z-0003ut-Pt for qemu-devel@nongnu.org; Wed, 14 Jun 2017 13:29:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59944) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dLC6z-0003uR-JL for qemu-devel@nongnu.org; Wed, 14 Jun 2017 13:29:45 -0400 From: Juan Quintela In-Reply-To: (Paolo Bonzini's message of "Wed, 14 Jun 2017 19:12:13 +0200") References: <149745954462.1611.12282014261512444009@4a9a010726c0> Reply-To: quintela@redhat.com Date: Wed, 14 Jun 2017 19:29:38 +0200 Message-ID: <871sqmcwal.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] vhost-user: support cross-endianess negatiation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Felipe Franciosi , QEMU Developers , "famz@redhat.com" , Mike Cui , "Michael S. Tsirkin" Paolo Bonzini wrote: > On 14/06/2017 19:02, Felipe Franciosi wrote: >>=20 >>> On 14 Jun 2017, at 17:59, no-reply@patchew.org wrote: >>> >>> Hi, >>> >>> This series failed automatic build test. Please find the testing comman= ds and >>> their output below. If you have docker installed, you can probably repr= oduce it >>> locally. >>> >>> Message-id: 1497458486-15673-1-git-send-email-felipe@nutanix.com >>> Type: series >>> Subject: [Qemu-devel] [PATCH] vhost-user: support cross-endianess negat= iation >>> >> ... >>> >>> CC hw/pci-bridge/pci_expander_bridge.o >>> In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: >>> /tmp/qemu-test/src/include/migration/register.h:18: error: >>> redefinition of typedef =E2=80=98LoadStateHandler=E2=80=99 >>> /tmp/qemu-test/src/include/migration/vmstate.h:32: note: previous >>> declaration of =E2=80=98LoadStateHandler=E2=80=99 was here >>> make: *** [hw/net/vmxnet3.o] Error 1 >>> make: *** Waiting for unfinished jobs.... >>> tests/docker/Makefile.include:118: recipe for target 'docker-run' failed >>> make[1]: *** [docker-run] Error 2 >>> make[1]: Leaving directory '/var/tmp/patchew-tester-tmp-enl3ixyr/src' >>> tests/docker/Makefile.include:149: recipe for target >>> 'docker-run-test-build@min-glib' failed >>> make: *** [docker-run-test-build@min-glib] Error 2 >>> =3D=3D=3D OUTPUT END =3D=3D=3D >>> >>> Test command exited with code: 2 >>=20 >> That seems completely unrelated to what our patch touched... I'm >> gonna guess this is a known issue and I can safely ignore it? > > Yes. > > Juan, can you take a look? Just removing the typedef from > VMStateDescription, and instead just using int(*load_state_old)(etc...) > should do it. There is a patch already on list, reviewed, and on a PULL request. Problem is that new complires don't complain about a repeated typedef. Older ones do. I compile on F25, and there it don't warn/error. Sorry for the noise. Later, Juan.