From: Juan Quintela <quintela@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Andrew Jones <drjones@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object
Date: Thu, 08 Jun 2017 16:23:34 +0200 [thread overview]
Message-ID: <871squblsp.fsf@secure.mitica> (raw)
In-Reply-To: <1496927934-21815-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Thu, 8 Jun 2017 15:18:54 +0200")
Thomas Huth <thuth@redhat.com> wrote:
> There does not seem to be any target specific code in core.c, so we can
> put it into "common-obj" instead of "obj" to compile it only once for
> all targets.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
It compiles.
I can't see anything that is target dependent on core.c.
So
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2017-06-08 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 13:18 [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object Thomas Huth
2017-06-08 14:23 ` Juan Quintela [this message]
2017-06-09 2:03 ` David Gibson
2017-06-09 13:20 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871squblsp.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).