From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIyLb-0005HS-DR for qemu-devel@nongnu.org; Thu, 08 Jun 2017 10:23:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIyLa-0004uK-Mn for qemu-devel@nongnu.org; Thu, 08 Jun 2017 10:23:39 -0400 From: Juan Quintela In-Reply-To: <1496927934-21815-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Thu, 8 Jun 2017 15:18:54 +0200") References: <1496927934-21815-1-git-send-email-thuth@redhat.com> Reply-To: quintela@redhat.com Date: Thu, 08 Jun 2017 16:23:34 +0200 Message-ID: <871squblsp.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Paolo Bonzini , Bharata B Rao , Eduardo Habkost , Igor Mammedov , David Gibson , Andrew Jones Thomas Huth wrote: > There does not seem to be any target specific code in core.c, so we can > put it into "common-obj" instead of "obj" to compile it only once for > all targets. > > Signed-off-by: Thomas Huth It compiles. I can't see anything that is target dependent on core.c. So Reviewed-by: Juan Quintela