From: Vincent Bernat <Vincent.Bernat@exoscale.ch>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Samuel Thibault <samuel.thibault@gnu.org>,
Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Qemu-devel] [v2] tftp: fake support for netascii protocol
Date: Mon, 21 Nov 2016 16:35:28 +0100 [thread overview]
Message-ID: <871sy4dewv.fsf@luffy.cx> (raw)
In-Reply-To: <20161121144616.GG15478@stefanha-x1.localdomain> (Stefan Hajnoczi's message of "Mon, 21 Nov 2016 14:46:16 +0000")
❦ 21 novembre 2016 14:46 GMT, Stefan Hajnoczi <stefanha@redhat.com> :
> The commit description says it would be "far more complex" to implement
> netascii. Is the LF -> CR LF and CR -> CR NUL transformation so hard?
Currently, the code uses lseek to send each block. It is just a matter
of doing nr_block*512. If there is a transformation, this cannot work
this way. But this can be done, we'll just have to maintain an offset.
Not knowing the final size is not a problem, just send back 0 as the
size.
--
Vincent Bernat — Vincent.Bernat@exoscale.ch
❬❱ https://www.exoscale.ch
next prev parent reply other threads:[~2016-11-21 15:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 17:51 [Qemu-devel] [PULL] tftp: fake support for netascii protocol Samuel Thibault
2016-11-18 17:51 ` Samuel Thibault
2016-11-18 17:55 ` no-reply
2016-11-19 7:32 ` Thomas Huth
2016-11-19 8:03 ` Vincent Bernat
2016-11-19 22:30 ` Samuel Thibault
2016-11-20 8:41 ` [Qemu-devel] [v2] " Vincent Bernat
2016-11-20 8:44 ` no-reply
2016-11-20 8:44 ` no-reply
2016-11-21 7:35 ` Thomas Huth
2016-11-21 14:46 ` Stefan Hajnoczi
2016-11-21 14:51 ` hpa
2016-11-21 15:05 ` Samuel Thibault
2016-11-21 15:28 ` hpa
2016-11-22 10:49 ` Stefan Hajnoczi
2016-11-23 7:30 ` Vincent Bernat
2016-11-23 9:34 ` Stefan Hajnoczi
2016-11-21 15:35 ` Vincent Bernat [this message]
2016-11-21 15:38 ` hpa
2016-11-20 8:42 ` [Qemu-devel] [PULL] " Vincent Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sy4dewv.fsf@luffy.cx \
--to=vincent.bernat@exoscale.ch \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@gnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).