Re: [Qemu-devel] [PATCH v4 03/35] exec: Avoid direct references to Int128 parts

["Alex Bennée" <alex.bennee@linaro.org>]

Richard Henderson <rth@twiddle.net> writes:

> Signed-off-by: Richard Henderson <rth@twiddle.net>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  exec.c                |  4 ++--
>  include/qemu/int128.h | 10 ++++++++++
>  2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index c8389f9..cc2997e 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -320,9 +320,9 @@ static inline bool section_covers_addr(const MemoryRegionSection *section,
>      /* Memory topology clips a memory region to [0, 2^64); size.hi > 0 means
>       * the section must cover the entire address space.
>       */
> -    return section->size.hi ||
> +    return int128_gethi(section->size) ||
>             range_covers_byte(section->offset_within_address_space,
> -                             section->size.lo, addr);
> +                             int128_getlo(section->size), addr);
>  }
>
>  static MemoryRegionSection *phys_page_find(PhysPageEntry lp, hwaddr addr,
> diff --git a/include/qemu/int128.h b/include/qemu/int128.h
> index c598881..52aaf99 100644
> --- a/include/qemu/int128.h
> +++ b/include/qemu/int128.h
> @@ -20,6 +20,16 @@ static inline uint64_t int128_get64(Int128 a)
>      return a.lo;
>  }
>
> +static inline uint64_t int128_getlo(Int128 a)
> +{
> +    return a.lo;
> +}
> +
> +static inline int64_t int128_gethi(Int128 a)
> +{
> +    return a.hi;
> +}
> +
>  static inline Int128 int128_zero(void)
>  {
>      return int128_make64(0);


--
Alex Bennée