From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpGio-00008L-Bx for qemu-devel@nongnu.org; Wed, 28 Sep 2016 11:24:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpGij-000717-8C for qemu-devel@nongnu.org; Wed, 28 Sep 2016 11:24:33 -0400 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:35176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpGij-000711-0O for qemu-devel@nongnu.org; Wed, 28 Sep 2016 11:24:29 -0400 Received: by mail-wm0-x229.google.com with SMTP id l132so241874035wmf.0 for ; Wed, 28 Sep 2016 08:24:28 -0700 (PDT) References: <1475047892-11955-1-git-send-email-famz@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1475047892-11955-1-git-send-email-famz@redhat.com> Date: Wed, 28 Sep 2016 16:24:25 +0100 Message-ID: <871t04vyhi.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] docker: Build in a clean directory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org Fam Zheng writes: > Currently we configure and build under "$QEMU_SRC/tests/docker" which is > dubious, create a fixed directory (to be friendly to ccache) and change > to there before calling build_qemu. > > Signed-off-by: Fam Zheng > --- > tests/docker/common.rc | 3 +++ > tests/docker/test-clang | 2 ++ > tests/docker/test-full | 2 ++ > tests/docker/test-mingw | 2 ++ > tests/docker/test-quick | 2 ++ > 5 files changed, 11 insertions(+) > > diff --git a/tests/docker/common.rc b/tests/docker/common.rc > index 510a3ad..21657e8 100755 > --- a/tests/docker/common.rc > +++ b/tests/docker/common.rc > @@ -11,6 +11,9 @@ > # or (at your option) any later version. See the COPYING file in > # the top-level directory. > > +BUILD_DIR=/var/tmp/qemu-build > +mkdir $BUILD_DIR Is that safe on multi-user machines? Also should we honour $TMPDIR if set? > + > requires() > { > for c in $@; do > diff --git a/tests/docker/test-clang b/tests/docker/test-clang > index 60e4e97..16485e6 100755 > --- a/tests/docker/test-clang > +++ b/tests/docker/test-clang > @@ -15,6 +15,8 @@ > > requires clang > > +cd "$BUILD_DIR" > + > OPTS="--enable-debug --cxx=clang++ --cc=clang --host-cc=clang" > # -fsanitize=undefined is broken on Fedora 23, skip it for now > # See also: https://bugzilla.redhat.com/show_bug.cgi?id=1263834 > diff --git a/tests/docker/test-full b/tests/docker/test-full > index fd9b798..05f0d49 100755 > --- a/tests/docker/test-full > +++ b/tests/docker/test-full > @@ -13,5 +13,7 @@ > > . common.rc > > +cd "$BUILD_DIR" > + > build_qemu > make check $MAKEFLAGS > diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw > index c03757a..3396876 100755 > --- a/tests/docker/test-mingw > +++ b/tests/docker/test-mingw > @@ -15,6 +15,8 @@ > > requires mingw dtc > > +cd "$BUILD_DIR" > + > for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do > TARGET_LIST=x86_64-softmmu,aarch64-softmmu \ > build_qemu --cross-prefix=$prefix \ > diff --git a/tests/docker/test-quick b/tests/docker/test-quick > index 7885dfa..c465dc0 100755 > --- a/tests/docker/test-quick > +++ b/tests/docker/test-quick > @@ -13,6 +13,8 @@ > > . common.rc > > +cd "$BUILD_DIR" > + > DEF_TARGET_LIST="x86_64-softmmu,aarch64-softmmu" > TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \ > build_qemu -- Alex Bennée