From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za0WI-0004mU-E7 for qemu-devel@nongnu.org; Thu, 10 Sep 2015 08:00:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za0WF-0006hi-7j for qemu-devel@nongnu.org; Thu, 10 Sep 2015 08:00:02 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:34749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za0WF-0006hZ-2F for qemu-devel@nongnu.org; Thu, 10 Sep 2015 07:59:59 -0400 Received: by wicfx3 with SMTP id fx3so25131431wic.1 for ; Thu, 10 Sep 2015 04:59:58 -0700 (PDT) References: <1440375847-17603-1-git-send-email-cota@braap.org> <1440375847-17603-11-git-send-email-cota@braap.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1440375847-17603-11-git-send-email-cota@braap.org> Date: Thu, 10 Sep 2015 12:59:57 +0100 Message-ID: <871te6a3ia.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC 10/38] translate-all: remove obsolete comment about l1_map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" Cc: mttcg@listserver.greensocs.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, guillaume.delbergue@greensocs.com, pbonzini@redhat.com, Frederic Konrad Emilio G. Cota writes: > l1_map is based on physical addresses in full-system mode, as pointed > out in an earlier comment. Said comment also mentions that virtual > addresses are only used in l1_map in user-only mode. > > Signed-off-by: Emilio G. Cota > --- > translate-all.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/translate-all.c b/translate-all.c > index 31239db..b873d5c 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -122,8 +122,7 @@ uintptr_t qemu_real_host_page_mask; > uintptr_t qemu_host_page_size; > uintptr_t qemu_host_page_mask; > > -/* This is a multi-level map on the virtual address space. > - The bottom level has pointers to PageDesc. */ > +/* The bottom level has pointers to PageDesc */ > static void *l1_map[V_L1_SIZE]; > > /* code generation context */ Reviewed-by: Alex Bennée -- Alex Bennée