From: Juan Quintela <quintela@redhat.com>
To: Liang Li <liang.z.li@intel.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com,
Yang Zhang <yang.z.zhang@intel.com>,
amit.shah@redhat.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters
Date: Wed, 08 Apr 2015 13:37:22 +0200 [thread overview]
Message-ID: <871tjun959.fsf@neno.neno> (raw)
In-Reply-To: <1428474011-30797-13-git-send-email-liang.z.li@intel.com> (Liang Li's message of "Wed, 8 Apr 2015 14:20:09 +0800")
Liang Li <liang.z.li@intel.com> wrote:
> Put the three parameters related to multiple thread (de)compression
> into an int array, and use an enum type to index the parameter.
>
> Signed-off-by: Liang Li <liang.z.li@intel.com>
> Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
BTW, for the libvirt people, what do you think about moving the other
parameters here, and make the other accessors deprecated?
I mean here:
- xbzrle_cache_size
-> get mbps
-> set/get migration_speed
-> get/set migration_downtime
-> autoconverge?
You get the idea.
Later, Juan.
next prev parent reply other threads:[~2015-04-08 11:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 6:19 [Qemu-devel] [PATCH v7 0/14] migration: Add a new feature to do live migration Liang Li
2015-04-08 6:19 ` [Qemu-devel] [v7 01/14] docs: Add a doc about multiple thread compression Liang Li
2015-04-08 6:19 ` [Qemu-devel] [v7 02/14] migration: Add the framework of multi-thread compression Liang Li
2015-04-08 6:20 ` [Qemu-devel] [v7 03/14] migration: Add the framework of multi-thread decompression Liang Li
2015-04-08 6:20 ` [Qemu-devel] [v7 04/14] qemu-file: Add compression functions to QEMUFile Liang Li
2015-04-08 6:20 ` [Qemu-devel] [v7 05/14] arch_init: Alloc and free data struct for compression Liang Li
2015-04-08 6:20 ` [Qemu-devel] [v7 06/14] arch_init: Add and free data struct for decompression Liang Li
2015-04-08 6:20 ` [Qemu-devel] [v7 07/14] migration: Split save_zero_page from ram_save_page Liang Li
2015-04-08 6:20 ` [Qemu-devel] [v7 08/14] migration: Add the core code of multi-thread compression Liang Li
2015-04-08 11:14 ` Juan Quintela
2015-04-08 6:20 ` [Qemu-devel] [v7 09/14] migration: Make compression co-work with xbzrle Liang Li
2015-04-08 11:26 ` Juan Quintela
2015-04-08 13:52 ` Li, Liang Z
2015-04-08 6:20 ` [Qemu-devel] [v7 10/14] migration: Add the core code for decompression Liang Li
2015-04-08 11:34 ` Juan Quintela
2015-04-08 14:00 ` Li, Liang Z
2015-04-08 14:48 ` Juan Quintela
2015-04-08 6:20 ` [Qemu-devel] [v7 11/14] migration: Add interface to control compression Liang Li
2015-04-08 11:34 ` Juan Quintela
2015-04-14 12:00 ` Eric Blake
2015-04-08 6:20 ` [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters Liang Li
2015-04-08 11:37 ` Juan Quintela [this message]
2015-04-14 12:01 ` Eric Blake
2015-04-14 12:03 ` Eric Blake
2015-04-15 8:13 ` Juan Quintela
2015-04-15 8:35 ` Li, Liang Z
2015-04-08 6:20 ` [Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters Liang Li
2015-04-08 11:39 ` Juan Quintela
2015-04-14 2:07 ` Li, Liang Z
2015-04-14 9:24 ` Juan Quintela
2015-04-14 12:09 ` Eric Blake
2015-04-14 12:16 ` Eric Blake
2015-04-08 6:20 ` [Qemu-devel] [v7 14/14] migration: Add hmp interface " Liang Li
2015-04-14 12:20 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tjun959.fsf@neno.neno \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=liang.z.li@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).