From: "Alex Bennée" <alex.bennee@linaro.org>
To: Anton Blanchard <anton@samba.org>
Cc: clg@fr.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
gkurz@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit
Date: Tue, 25 Mar 2014 07:29:01 +0000 [thread overview]
Message-ID: <871txqspmq.fsf@linaro.org> (raw)
In-Reply-To: <1395715231-4217-1-git-send-email-anton@samba.org>
Anton Blanchard <anton@samba.org> writes:
> Add MSR_LE to the msr_mask for POWER8.
>
<snip>
> - pcc->msr_mask = 0x800000000284FF36ULL;
> + pcc->msr_mask = 0x800000000284FF37ULL;
<snip>
Should we be adding some #define's for the various bit positions on this
mask? Looking at the current code it looks like a big ream of magic
numbers.
Cheers,
--
Alex Bennée
next prev parent reply other threads:[~2014-03-25 7:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 2:40 [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit Anton Blanchard
2014-03-25 2:40 ` [Qemu-devel] [PATCH 2/6] target-ppc: POWER8 supports isel Anton Blanchard
2014-03-25 2:40 ` [Qemu-devel] [PATCH 3/6] target-ppc: POWER7+ supports the MSR_VSX bit Anton Blanchard
2014-03-25 2:40 ` [Qemu-devel] [PATCH 4/6] target-ppc: MSR_POW not supported on POWER7/7+/8 Anton Blanchard
2014-03-25 2:40 ` [Qemu-devel] [PATCH 5/6] target-ppc: Fix Book3S PMU SPRs Anton Blanchard
2014-04-10 13:22 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-03-25 2:40 ` [Qemu-devel] [PATCH 6/6] target-ppc: Add PMC7/8 to 970 Anton Blanchard
2014-03-27 13:03 ` [Qemu-devel] [Qemu-ppc] " Alexey Kardashevskiy
2014-03-27 15:40 ` Andreas Färber
2014-04-10 13:24 ` Alexander Graf
2014-03-25 7:29 ` Alex Bennée [this message]
2014-03-27 14:58 ` [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit Andreas Färber
2014-03-27 17:10 ` Tom Musta
2014-03-27 15:36 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871txqspmq.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=anton@samba.org \
--cc=clg@fr.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).