From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32803)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1WLtX4-0000eo-UB
	for qemu-devel@nongnu.org; Fri, 07 Mar 2014 07:05:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1WLtX0-00061x-F8
	for qemu-devel@nongnu.org; Fri, 07 Mar 2014 07:05:42 -0500
References: <1394187082-31986-1-git-send-email-sw@weilnetz.de>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
Message-ID: <871tyecixy.fsf@linaro.org>
In-reply-to: <1394187082-31986-1-git-send-email-sw@weilnetz.de>
Date: Fri, 07 Mar 2014 12:06:00 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] tests: Fix 'make test' for i686 hosts
	(buildregression))
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <rth@twiddle.net>, qemu-stable@nongnu.org, qemu-devel@nongnu.org


Stefan Weil <sw@weilnetz.de> writes:

> 'make test' is broken at least since commit
> baacf04799ace72a9c735dd9306a1ceaf305e7cf. Several source files were moved
> to util/, and some of them there split, so add the missing prefix and new
> files to fix the compiler and linker errors.

I'm curious as why the Travis builds didn't pick this up?

https://travis-ci.org/qemu/qemu/builds

Does it require more libraries/features enabled to cause the breakage?

>
> There remain more issues, but these changes allow running the test on a
> Linux i686 host.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> 'make test' shows several problems where the results from native
> execution and user mode emulation differ. Obviously the TCG code
> or at least one helper function don't work as expected.
>
> The patch might be useful for QEMU stable, too. I did not use it
> with older versions, so I still don't know whether there was a TCG
> regression and when it occurred.
>
> Running 'make test' on an x86_64 host is currently not possible.
> There is at least one -m32 compiler option missing, and a 32 bit
> version of glib2.0 must be installed (not available for Debian
> wheezy, so I had to stop here).
>
> Regards
> Stefan
>
>  tests/tcg/test_path.c |   13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/tests/tcg/test_path.c b/tests/tcg/test_path.c
> index a064eea..f8dd36a 100644
> --- a/tests/tcg/test_path.c
> +++ b/tests/tcg/test_path.c
> @@ -1,12 +1,15 @@
>  /* Test path override code */
>  #define _GNU_SOURCE
>  #include "config-host.h"
> -#include "iov.c"
> -#include "cutils.c"
> -#include "path.c"
> -#include "trace.c"
> +#include "util/cutils.c"
> +#include "util/hexdump.c"
> +#include "util/iov.c"
> +#include "util/path.c"
> +#include "util/qemu-timer-common.c"
> +#include "trace/control.c"
> +#include "../trace/generated-events.c"
>  #ifdef CONFIG_TRACE_SIMPLE
> -#include "../trace/simple.c"
> +#include "trace/simple.c"
>  #endif
>  
>  #include <stdarg.h>

-- 
Alex Bennée