From: Juan Quintela <quintela@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] exec: fix ram_list dirty map optimization
Date: Tue, 04 Feb 2014 16:00:54 +0100 [thread overview]
Message-ID: <871tzikjmh.fsf@elfo.mitica> (raw)
In-Reply-To: <1391083430-25332-1-git-send-email-aik@ozlabs.ru> (Alexey Kardashevskiy's message of "Thu, 30 Jan 2014 23:03:50 +1100")
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> The ae2810c4bb3b383176e8e1b33931b16c01483aab patch introduced
> optimization for ram_list.dirty_memory update. However it can only
> work correctly if hpratio is 1 as the @bitmap parameter stores 1 bits
> per system page size (may vary, 4K or 64K on PPC64) and
> ram_list.dirty_memory stores 1 bit per TARGET_PAGE_SIZE
> (which is hardcoded to 4K).
>
> This fixes hpratio!=1 case to fall back to the slow path.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Juan Quintela <quintela@redhat.com>
prev parent reply other threads:[~2014-02-04 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 12:03 [Qemu-devel] [PATCH] exec: fix ram_list dirty map optimization Alexey Kardashevskiy
2014-02-04 15:00 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tzikjmh.fsf@elfo.mitica \
--to=quintela@redhat.com \
--cc=aik@ozlabs.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).