From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAhUw-00033C-OI for qemu-devel@nongnu.org; Tue, 04 Feb 2014 10:01:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAhUr-000403-Om for qemu-devel@nongnu.org; Tue, 04 Feb 2014 10:01:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12607) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAhUr-0003zw-GW for qemu-devel@nongnu.org; Tue, 04 Feb 2014 10:01:09 -0500 From: Juan Quintela In-Reply-To: <1391083430-25332-1-git-send-email-aik@ozlabs.ru> (Alexey Kardashevskiy's message of "Thu, 30 Jan 2014 23:03:50 +1100") References: <1391083430-25332-1-git-send-email-aik@ozlabs.ru> Date: Tue, 04 Feb 2014 16:00:54 +0100 Message-ID: <871tzikjmh.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] exec: fix ram_list dirty map optimization Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Paolo Bonzini , qemu-devel@nongnu.org Alexey Kardashevskiy wrote: > The ae2810c4bb3b383176e8e1b33931b16c01483aab patch introduced > optimization for ram_list.dirty_memory update. However it can only > work correctly if hpratio is 1 as the @bitmap parameter stores 1 bits > per system page size (may vary, 4K or 64K on PPC64) and > ram_list.dirty_memory stores 1 bit per TARGET_PAGE_SIZE > (which is hardcoded to 4K). > > This fixes hpratio!=1 case to fall back to the slow path. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Juan Quintela