* Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor
2013-06-03 21:14 [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor Anthony Liguori
@ 2013-06-04 7:51 ` Gerd Hoffmann
2013-06-04 12:08 ` Andreas Färber
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Gerd Hoffmann @ 2013-06-04 7:51 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
On 06/03/13 23:14, Anthony Liguori wrote:
> - g_object_unref(cursor);
> + gdk_cursor_unref(cursor);
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor
2013-06-03 21:14 [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor Anthony Liguori
2013-06-04 7:51 ` Gerd Hoffmann
@ 2013-06-04 12:08 ` Andreas Färber
2013-06-04 15:35 ` Anthony Liguori
2013-06-10 21:48 ` Anthony Liguori
` (2 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Andreas Färber @ 2013-06-04 12:08 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Gerd Hoffman
Am 03.06.2013 23:14, schrieb Anthony Liguori:
> It's not a GObject.
>
> Cc: Gerd Hoffman <kraxel@redhat.com>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> v1 -> v2
> - Fix summary to agree with code (Peter)
> ---
> ui/gtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Seems this was accidentally cherry-picked rather than git-am'ed. ;)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor
2013-06-04 12:08 ` Andreas Färber
@ 2013-06-04 15:35 ` Anthony Liguori
0 siblings, 0 replies; 7+ messages in thread
From: Anthony Liguori @ 2013-06-04 15:35 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-devel, Gerd Hoffman
Andreas Färber <afaerber@suse.de> writes:
> Am 03.06.2013 23:14, schrieb Anthony Liguori:
>> It's not a GObject.
>>
>> Cc: Gerd Hoffman <kraxel@redhat.com>
>> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>> ---
>> v1 -> v2
>> - Fix summary to agree with code (Peter)
>> ---
>> ui/gtk.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Seems this was accidentally cherry-picked rather than git-am'ed. ;)
Sort of, but yes.
Regards,
Anthony Liguori
>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor
2013-06-03 21:14 [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor Anthony Liguori
2013-06-04 7:51 ` Gerd Hoffmann
2013-06-04 12:08 ` Andreas Färber
@ 2013-06-10 21:48 ` Anthony Liguori
2013-07-22 20:36 ` Bruce Rogers
2013-07-22 20:37 ` Bruce Rogers
4 siblings, 0 replies; 7+ messages in thread
From: Anthony Liguori @ 2013-06-10 21:48 UTC (permalink / raw)
To: Anthony Liguori, qemu-devel; +Cc: Gerd Hoffman
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor
2013-06-03 21:14 [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor Anthony Liguori
` (2 preceding siblings ...)
2013-06-10 21:48 ` Anthony Liguori
@ 2013-07-22 20:36 ` Bruce Rogers
2013-07-22 20:37 ` Bruce Rogers
4 siblings, 0 replies; 7+ messages in thread
From: Bruce Rogers @ 2013-07-22 20:36 UTC (permalink / raw)
To: qemu-devel, Anthony Liguori; +Cc: qemu-stable, Gerd Hoffman
>>> On 6/3/2013 at 03:14 PM, Anthony Liguori <aliguori@us.ibm.com> wrote:
> It's not a GObject.
>
> Cc: Gerd Hoffman <kraxel@redhat.com>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> v1 -> v2
> - Fix summary to agree with code (Peter)
> ---
> ui/gtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 8dc9041..3bc2842 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -377,7 +377,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl,
> pixbuf, c->hot_x, c->hot_y);
> gdk_window_set_cursor(gtk_widget_get_window(s->drawing_area), cursor);
> g_object_unref(pixbuf);
> - g_object_unref(cursor);
> + gdk_cursor_unref(cursor);
> }
>
> static void gd_switch(DisplayChangeListener *dcl,
This is a candidate for the 1.5.2 stable release.
Bruce
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor
2013-06-03 21:14 [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor Anthony Liguori
` (3 preceding siblings ...)
2013-07-22 20:36 ` Bruce Rogers
@ 2013-07-22 20:37 ` Bruce Rogers
4 siblings, 0 replies; 7+ messages in thread
From: Bruce Rogers @ 2013-07-22 20:37 UTC (permalink / raw)
To: qemu-devel, Anthony Liguori; +Cc: qemu-stable, Gerd Hoffman
>>> On 6/3/2013 at 03:14 PM, Anthony Liguori <aliguori@us.ibm.com> wrote:
> It's not a GObject.
>
> Cc: Gerd Hoffman <kraxel@redhat.com>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> v1 -> v2
> - Fix summary to agree with code (Peter)
> ---
> ui/gtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 8dc9041..3bc2842 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -377,7 +377,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl,
> pixbuf, c->hot_x, c->hot_y);
> gdk_window_set_cursor(gtk_widget_get_window(s->drawing_area), cursor);
> g_object_unref(pixbuf);
> - g_object_unref(cursor);
> + gdk_cursor_unref(cursor);
> }
>
> static void gd_switch(DisplayChangeListener *dcl,
This is a candidate for the 1.5.2 stable release.
Bruce
^ permalink raw reply [flat|nested] 7+ messages in thread