From: Anthony Liguori <aliguori@us.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] char: introduce a blocking version of qemu_chr_fe_write
Date: Wed, 27 Mar 2013 18:01:00 -0500 [thread overview]
Message-ID: <871ub0zbv7.fsf@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA98mqn_-oPjK6S7aJ7LmjjuNeVg7AyUw5QVr=gD0_QedA@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 27 March 2013 21:15, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> Applied. Thanks.
>
> Replied to wrong email by accident, or applied ignoring
> the review comments?
I interpreted your comment as a suggestion. I'm not a fan of while
(true) loops so I left it as is. Since it's a pretty important bug fix
(make check was failing), I tried to get it applied quickly. I should
have responded to your mail before applying it though.
Regards,
Anthony Liguori
>
> -- PMM
prev parent reply other threads:[~2013-03-27 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 15:11 [Qemu-devel] [PATCH 1/2] char: introduce a blocking version of qemu_chr_fe_write Anthony Liguori
2013-03-26 15:11 ` [Qemu-devel] [PATCH 2/2] qtest: use synchronous I/O for char device Anthony Liguori
2013-03-27 7:22 ` Wenchao Xia
2013-03-26 15:21 ` [Qemu-devel] [PATCH 1/2] char: introduce a blocking version of qemu_chr_fe_write Peter Maydell
2013-03-27 7:21 ` Wenchao Xia
2013-03-27 21:15 ` Anthony Liguori
2013-03-27 22:05 ` Peter Maydell
2013-03-27 23:01 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ub0zbv7.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).