From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGugJ-0000PT-GU for qemu-devel@nongnu.org; Wed, 26 Sep 2012 12:41:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGugA-0007bq-PD for qemu-devel@nongnu.org; Wed, 26 Sep 2012 12:41:51 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:47822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGugA-0007al-IB for qemu-devel@nongnu.org; Wed, 26 Sep 2012 12:41:42 -0400 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Sep 2012 10:41:41 -0600 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 67B433E40067 for ; Wed, 26 Sep 2012 10:41:36 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8QGfEGt053126 for ; Wed, 26 Sep 2012 10:41:19 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8QGf98G021438 for ; Wed, 26 Sep 2012 10:41:14 -0600 From: Anthony Liguori In-Reply-To: <1348668925.28860.173.camel@bling.home> References: <20120926033554.29058.30735.stgit@bling.home> <20120926033856.29058.47896.stgit@bling.home> <87bogsj3kl.fsf@codemonkey.ws> <1348668925.28860.173.camel@bling.home> Date: Wed, 26 Sep 2012 11:41:01 -0500 Message-ID: <871uhoohya.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [RESEND PATCH v5 4/4] vfio: Enable vfio-pci and mark supported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: kvm@vger.kernel.org, aik@ozlabs.ru, jan.kiszka@siemens.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, avi@redhat.com Alex Williamson writes: > On Wed, 2012-09-26 at 08:50 -0500, Anthony Liguori wrote: >> Alex Williamson writes: >> >> > Enabled for all softmmu guests supporting PCI on Linux hosts. Note >> > that currently only x86 hosts have the kernel side VFIO IOMMU support >> > for this. PPC (g3beige) is the only non-x86 guest known to work. >> > ARM (veratile) hangs in firmware, others untested. >> > >> > Signed-off-by: Alex Williamson >> > Acked-by: Michael S. Tsirkin >> > --- >> > >> > MAINTAINERS | 5 +++++ >> > configure | 6 ++++++ >> > hw/Makefile.objs | 3 ++- >> > 3 files changed, 13 insertions(+), 1 deletion(-) >> > >> > diff --git a/MAINTAINERS b/MAINTAINERS >> > index 25733fc..29aac4f 100644 >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -474,6 +474,11 @@ M: Gerd Hoffmann >> > S: Maintained >> > F: hw/usb* >> > >> > +VFIO >> > +M: Alex Williamson >> > +S: Supported >> > +F: hw/vfio* >> > + >> > vhost >> > M: Michael S. Tsirkin >> > S: Supported >> > diff --git a/configure b/configure >> > index 1b86517..c2c0d4f 100755 >> > --- a/configure >> > +++ b/configure >> > @@ -165,6 +165,7 @@ attr="" >> > libattr="" >> > xfs="" >> > >> > +vfio_pci="no" >> > vhost_net="no" >> > kvm="no" >> > gprof="no" >> > @@ -509,6 +510,7 @@ Haiku) >> > usb="linux" >> > kvm="yes" >> > vhost_net="yes" >> > + vfio_pci="yes" >> > if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then >> > audio_possible_drivers="$audio_possible_drivers fmod" >> > fi >> > @@ -3174,6 +3176,7 @@ echo "libiscsi support $libiscsi" >> > echo "build guest agent $guest_agent" >> > echo "seccomp support $seccomp" >> > echo "coroutine backend $coroutine_backend" >> > +echo "VFIO PCI support $vfio_pci" >> > >> > if test "$sdl_too_old" = "yes"; then >> > echo "-> Your SDL version is too old - please upgrade to have SDL support" >> > @@ -3911,6 +3914,9 @@ if test "$target_softmmu" = "yes" ; then >> > if test "$smartcard_nss" = "yes" ; then >> > echo "subdir-$target: subdir-libcacard" >> $config_host_mak >> > fi >> > + if test "$vfio_pci" = "yes" ; then >> > + echo "CONFIG_VFIO_PCI=y" >> $config_target_mak >> > + fi >> > case "$target_arch2" in >> > i386|x86_64) >> > echo "CONFIG_HAVE_CORE_DUMP=y" >> $config_target_mak >> > diff --git a/hw/Makefile.objs b/hw/Makefile.objs >> > index 6dfebd2..7f8d3e4 100644 >> > --- a/hw/Makefile.objs >> > +++ b/hw/Makefile.objs >> > @@ -198,7 +198,8 @@ obj-$(CONFIG_VGA) += vga.o >> > obj-$(CONFIG_SOFTMMU) += device-hotplug.o >> > obj-$(CONFIG_XEN) += xen_domainbuild.o xen_machine_pv.o >> > >> > -# Inter-VM PCI shared memory >> > +# Inter-VM PCI shared memory & VFIO PCI device assignment >> > ifeq ($(CONFIG_PCI), y) >> > obj-$(CONFIG_KVM) += ivshmem.o >> > +obj-$(CONFIG_VFIO_PCI) += vfio_pci.o >> >> Why not just make this >> >> obj-$(CONFIG_LINUX) += vfio_pci.o >> >> ? >> >> All you're doing in configure is setting CONFIG_VFIO_PCI if >> CONFIG_LINUX. > > Ok. I thought I needed linux + softmmu + pci, but maybe the softmmu is > implied with CONFIG_PCI? Thanks, obj-y is only used for softmmu so your covered. Regards, Anthony Liguori > > Alex > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html