From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RO3IO-0006Bu-H8 for qemu-devel@nongnu.org; Wed, 09 Nov 2011 03:14:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RO3IK-0008TT-Dg for qemu-devel@nongnu.org; Wed, 09 Nov 2011 03:14:08 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:47855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RO3IK-0008TG-8V for qemu-devel@nongnu.org; Wed, 09 Nov 2011 03:14:04 -0500 Received: from /spool/local by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Nov 2011 03:14:02 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pA98D8Qi317102 for ; Wed, 9 Nov 2011 03:13:08 -0500 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pA98D8Wr008822 for ; Wed, 9 Nov 2011 01:13:08 -0700 From: "Aneesh Kumar K.V" In-Reply-To: <1320819951-5302-1-git-send-email-harsh@linux.vnet.ibm.com> References: <1320819951-5302-1-git-send-email-harsh@linux.vnet.ibm.com> Date: Wed, 09 Nov 2011 13:43:00 +0530 Message-ID: <871uth90j7.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] scripts/analyse-9p-simpletrace.py: Add symbolic names for 9p operations. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Harsh Prateek Bora , qemu-devel@nongnu.org On Wed, 9 Nov 2011 11:55:51 +0530, Harsh Prateek Bora wrote: > Currently, we just print the numerical value of 9p operation identifier in > case of RERROR which is less meaningful for readability. Mapping 9p > operation ids to symbolic names provides a better tracelog: > > RERROR (tag = 1 , id = TWALK , err = 2 ) > RERROR (tag = 1 , id = TUNLINKAT , err = 39 ) It would be nice to map that err to a string. os.strerror(err) may be ? > > This patch provides a dictionary of all possible 9p operation symbols mapped > to their numerical identifiers which are likely to be used in future at > various places in this script. > > Signed-off-by: Harsh Prateek Bora > --- -aneesh