From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 5/6] pci_create() is now unused, remove it
Date: Fri, 25 Sep 2009 03:53:52 +0200 [thread overview]
Message-ID: <8721aff8e0dee1476a4bdd88e6d9abbf77277dfa.1253843233.git.armbru@redhat.com> (raw)
In-Reply-To: <cover.1253843232.git.armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/pci.c | 18 ------------------
hw/pci.h | 1 -
2 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index e43b53e..ec0fc7c 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -764,24 +764,6 @@ void pci_info(Monitor *mon)
pci_for_each_device(0, pci_info_device);
}
-PCIDevice *pci_create(const char *name, const char *devaddr)
-{
- PCIBus *bus;
- int devfn;
- DeviceState *dev;
-
- bus = pci_get_bus_devfn(&devfn, devaddr);
- if (!bus) {
- fprintf(stderr, "Invalid PCI device address %s for device %s\n",
- devaddr, name);
- exit(1);
- }
-
- dev = qdev_create(&bus->qbus, name);
- qdev_prop_set_uint32(dev, "addr", devfn);
- return (PCIDevice *)dev;
-}
-
static const char * const pci_nic_models[] = {
"ne2k_pci",
"i82551",
diff --git a/hw/pci.h b/hw/pci.h
index 51c5085..689461f 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -336,7 +336,6 @@ typedef struct {
void pci_qdev_register(PCIDeviceInfo *info);
void pci_qdev_register_many(PCIDeviceInfo *info);
-PCIDevice *pci_create(const char *name, const char *devaddr);
PCIDevice *pci_create_noinit(PCIBus *bus, int devfn, const char *name);
PCIDevice *pci_create_simple(PCIBus *bus, int devfn, const char *name);
--
1.6.2.5
next prev parent reply other threads:[~2009-09-25 1:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 1:53 [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fixes Markus Armbruster
2009-09-25 1:53 ` [Qemu-devel] [PATCH 1/6] Fix pci_vga_init() not to ignore bus argument Markus Armbruster
2009-09-25 1:53 ` [Qemu-devel] [PATCH 2/6] Fix pci_add storage not to exit on bad first argument Markus Armbruster
2009-09-25 16:36 ` [Qemu-devel] " Markus Armbruster
2009-09-25 1:53 ` [Qemu-devel] [PATCH 3/6] Make it obvious that pci_nic_init() can't fail Markus Armbruster
2009-09-25 1:53 ` [Qemu-devel] [PATCH 4/6] Fix pci_add nic not to exit on bad model Markus Armbruster
2009-09-25 1:53 ` Markus Armbruster [this message]
2009-09-25 1:53 ` [Qemu-devel] [PATCH 6/6] Rename pci_create_noinit() to pci_create() Markus Armbruster
2009-09-25 10:44 ` [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fixes Gerd Hoffmann
2009-09-25 14:12 ` Markus Armbruster
2009-09-25 16:26 ` Luiz Capitulino
2009-09-28 16:05 ` Mark McLoughlin
2009-09-28 16:16 ` Mark McLoughlin
2009-09-28 19:14 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8721aff8e0dee1476a4bdd88e6d9abbf77277dfa.1253843233.git.armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).