From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Chris Wulff <crwulff@gmail.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
David Hildenbrand <david@redhat.com>,
Anthony Green <green@moxielogic.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
QEMU Developers <qemu-devel@nongnu.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Marek Vasut <marex@denx.de>, Palmer Dabbelt <palmer@dabbelt.com>,
Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>,
Richard Henderson <rth@twiddle.net>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-s390x <qemu-s390x@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>, Stafford Horne <shorne@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Cornelia Huck <cohuck@redhat.com>,
Laurent Vivier <laurent@vivier.eu>,
Michael Walle <michael@walle.cc>, qemu-ppc <qemu-ppc@nongnu.org>,
Aleksandar Markovic <amarkovic@wavecomp.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset
Date: Wed, 4 Mar 2020 01:10:17 +0100 [thread overview]
Message-ID: <87269add-a5f1-4dca-9ae8-de392d7dbfd7@redhat.com> (raw)
In-Reply-To: <CAFEAcA-H9nOzSon9eqiL5w1Rq9qVWu=B1q29D4pLTd=u2cWSwQ@mail.gmail.com>
On 3/3/20 7:36 PM, Peter Maydell wrote:
> On Tue, 3 Mar 2020 at 18:33, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>> Nitpick: you don't need to include the bracket symbol in the diff:
>>
>> @@
>> -resetfn(CPUState *cpu)
>> +resetfn(DeviceState *dev)
>> {
>>
>> (simply indent it with a space).
>
> I think this was probably leftover from trying to get Coccinelle
> to not rewrap the '{' onto the previous line, before I found
> --smpl-spacing.
>
> In general I don't find it terribly useful to spend a great
> deal of time streamlining Coccinelle scripts -- I think they
> are basically one-shot uses almost all of the time, so once
> they're producing the right changes I prefer to move on.
I agree in this case it is not useful to add the script to the
repository as a file, because the cleanup is done (as you said,
'one-shot script'). The script is however valuable as in the commit
description.
Cleaning it up is not for performance, but as the script is buried into
the git repository, it can (and will) be used as reference/example by
other developers.
Anyway this patch is queued now, so let's move on :)
next prev parent reply other threads:[~2020-03-04 0:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 10:05 [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset Peter Maydell
2020-03-03 10:09 ` no-reply
2020-03-03 10:09 ` no-reply
2020-03-03 10:11 ` no-reply
2020-03-03 10:12 ` no-reply
2020-03-03 14:19 ` Philippe Mathieu-Daudé
2020-03-03 18:33 ` Philippe Mathieu-Daudé
2020-03-03 18:36 ` Peter Maydell
2020-03-04 0:10 ` Philippe Mathieu-Daudé [this message]
2020-03-03 18:41 ` Richard Henderson
2020-03-03 18:45 ` Eduardo Habkost
2020-03-03 22:19 ` David Gibson
2020-03-09 11:02 ` Christian Borntraeger
2020-03-17 11:01 ` Philippe Mathieu-Daudé
2020-03-17 11:09 ` Peter Maydell
2020-03-17 14:36 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87269add-a5f1-4dca-9ae8-de392d7dbfd7@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=cohuck@redhat.com \
--cc=crwulff@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=green@moxielogic.com \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).