Re: [PATCH] meson.build: Bump the minimum GCC version to v10.4

[Fabiano Rosas <farosas@suse.de>]

Thomas Huth <thuth@redhat.com> writes:

> From: Thomas Huth <thuth@redhat.com>
>
> Our minimum supported version of GCC used to be v7.4 since we still
> wanted to support NetBSD 9.x in the past:
>
>  https://gitlab.com/qemu-project/qemu/-/issues/614
>  https://gitlab.com/qemu-project/qemu/-/commit/3830df5f83b9b52d949676
>
> However, NetBSD 10 has already been released since two years ago
> (see https://www.netbsd.org/releases/formal-10/NetBSD-10.0.html),
> so according to our support policy, starting with QEMU v11.0, we
> don't have to take care of the previous major release of NetBSD
> anymore.
>
> Looking at the various distros that we take care of (see e.g.
> https://repology.org/project/gcc/versions), and the NetBSD 10.0
> 3rd party package information:
>
>  https://cvsweb.netbsd.org/bsdweb.cgi/src/doc/3RDPARTY?rev=1.1905.2.14;content-type=text%2Fplain;only_with_tag=netbsd-10-0-RELEASE
>
> ... it seems like NetBSD 10 has the lowest version of GCC again,
> but at least it's GCC 10.4 now. Thus bump our GCC requirement to
> this version now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index f45885f05a1..6ccca2325a7 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -325,7 +325,7 @@ endif
>  
>  foreach lang : all_languages
>    compiler = meson.get_compiler(lang)
> -  if compiler.get_id() == 'gcc' and compiler.version().version_compare('>=7.4')
> +  if compiler.get_id() == 'gcc' and compiler.version().version_compare('>=10.4')
>      # ok
>    elif compiler.get_id() == 'clang' and compiler.compiles('''
>        #ifdef __apple_build_version__
> @@ -341,7 +341,7 @@ foreach lang : all_languages
>    elif compiler.get_id() == 'emscripten'
>      # ok
>    else
> -    error('You either need GCC v7.4 or Clang v10.0 (or XCode Clang v15.0) to compile QEMU')
> +    error('You either need GCC v10.4 or Clang v10.0 (or XCode Clang v15.0) to compile QEMU')
>    endif
>  endforeach

Acked-by: Fabiano Rosas <farosas@suse.de>