Re: [PATCH v12 27/27] backends/tpm: Propagate vTPM error on migration failure

[Fabiano Rosas <farosas@suse.de>]

Arun Menon <armenon@redhat.com> writes:

> - When migration of a VM with encrypted vTPM fails on the
>   destination host, (e.g., due to a mismatch in secret values),
>   the error message displayed on the source host is generic and unhelpful.
> - For example, a typical error looks like this:
>   "operation failed: job 'migration out' failed: Sibling indicated error 1.
>   operation failed: job 'migration in' failed: load of migration failed:
>   Input/output error"
> - Such generic errors are logged using error_report(), which prints to
>   the console/monitor but does not make the detailed error accessible via
>   the QMP query-migrate command.
> - This change, along with the set of changes of passing errp Error object
>   to the VM state loading functions, help in addressing the issue.
>   We use the post_load_errp hook of VMStateDescription to propagate errors
>   by setting Error **errp objects in case of failure in the TPM backend.
> - It can then be retrieved using QMP command:
>   {"execute" : "query-migrate"}
>
> Buglink: https://issues.redhat.com/browse/RHEL-82826
>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Arun Menon <armenon@redhat.com>

Reviewed-by: Fabiano Rosas <farosas@suse.de>