From: Fabiano Rosas <farosas@suse.de>
To: Arun Menon <armenon@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Xu" <peterx@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Akihiko Odaki" <odaki@rsg.ci.i.u-tokyo.ac.jp>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"David Hildenbrand" <david@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>,
"Steve Sistare" <steven.sistare@oracle.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
"Hailiang Zhang" <zhanghailiang@xfusion.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Arun Menon" <armenon@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v9 12/27] migration: Update qemu_file_get_return_path() docs and remove dead checks
Date: Fri, 08 Aug 2025 10:07:04 -0300 [thread overview]
Message-ID: <8734a22c93.fsf@suse.de> (raw)
In-Reply-To: <20250805-propagate_tpm_error-v9-12-123450810db7@redhat.com>
Arun Menon <armenon@redhat.com> writes:
> The documentation of qemu_file_get_return_path() states that it can
> return NULL on failure. However, a review of the current implementation
> reveals that it is guaranteed that it will always succeed and will never
> return NULL.
>
> As a result, the NULL checks post calling the function become redundant.
> This commit updates the documentation for the function and removes all
> NULL checks throughout the migration code.
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Arun Menon <armenon@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2025-08-08 13:07 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 18:25 [PATCH v9 00/27] migration: propagate vTPM errors using Error objects Arun Menon
2025-08-05 18:25 ` [PATCH v9 01/27] migration: push Error **errp into vmstate_subsection_load() Arun Menon
2025-08-05 18:25 ` [PATCH v9 02/27] migration: push Error **errp into vmstate_load_state() Arun Menon
2025-08-06 8:31 ` Marc-André Lureau
2025-08-06 9:47 ` Arun Menon
2025-08-10 4:47 ` Akihiko Odaki
2025-08-05 18:25 ` [PATCH v9 03/27] migration: push Error **errp into qemu_loadvm_state_header() Arun Menon
2025-08-05 18:25 ` [PATCH v9 04/27] migration: push Error **errp into vmstate_load() Arun Menon
2025-08-05 18:25 ` [PATCH v9 05/27] migration: push Error **errp into loadvm_process_command() Arun Menon
2025-08-06 8:31 ` Marc-André Lureau
2025-08-06 9:46 ` Arun Menon
2025-08-05 18:25 ` [PATCH v9 06/27] migration: push Error **errp into loadvm_handle_cmd_packaged() Arun Menon
2025-08-05 18:25 ` [PATCH v9 07/27] migration: push Error **errp into qemu_loadvm_state() Arun Menon
2025-08-06 5:17 ` Akihiko Odaki
2025-08-07 6:07 ` Arun Menon
2025-08-06 7:24 ` Marc-André Lureau
2025-08-05 18:25 ` [PATCH v9 08/27] migration: push Error **errp into qemu_load_device_state() Arun Menon
2025-08-06 7:27 ` Marc-André Lureau
2025-08-05 18:25 ` [PATCH v9 09/27] migration: push Error **errp into qemu_loadvm_state_main() Arun Menon
2025-08-06 5:14 ` Akihiko Odaki
2025-08-06 7:34 ` Marc-André Lureau
2025-08-06 7:43 ` Arun Menon
2025-08-05 18:25 ` [PATCH v9 10/27] migration: push Error **errp into qemu_loadvm_section_start_full() Arun Menon
2025-08-06 7:37 ` Marc-André Lureau
2025-08-05 18:25 ` [PATCH v9 11/27] migration: push Error **errp into qemu_loadvm_section_part_end() Arun Menon
2025-08-06 7:46 ` Marc-André Lureau
2025-08-05 18:25 ` [PATCH v9 12/27] migration: Update qemu_file_get_return_path() docs and remove dead checks Arun Menon
2025-08-08 13:07 ` Fabiano Rosas [this message]
2025-08-05 18:25 ` [PATCH v9 13/27] migration: make loadvm_postcopy_handle_resume() void Arun Menon
2025-08-08 13:08 ` Fabiano Rosas
2025-08-05 18:25 ` [PATCH v9 14/27] migration: push Error **errp into ram_postcopy_incoming_init() Arun Menon
2025-08-05 18:25 ` [PATCH v9 15/27] migration: push Error **errp into loadvm_postcopy_handle_advise() Arun Menon
2025-08-05 18:25 ` [PATCH v9 16/27] migration: push Error **errp into loadvm_postcopy_handle_listen() Arun Menon
2025-08-05 18:25 ` [PATCH v9 17/27] migration: push Error **errp into loadvm_postcopy_handle_run() Arun Menon
2025-08-05 18:25 ` [PATCH v9 18/27] migration: push Error **errp into loadvm_postcopy_ram_handle_discard() Arun Menon
2025-08-06 7:54 ` Marc-André Lureau
2025-08-07 6:06 ` Arun Menon
2025-08-05 18:25 ` [PATCH v9 19/27] migration: push Error **errp into loadvm_handle_recv_bitmap() Arun Menon
2025-08-05 18:25 ` [PATCH v9 20/27] migration: push Error **errp into loadvm_process_enable_colo() Arun Menon
2025-08-06 8:07 ` Marc-André Lureau
2025-08-06 9:56 ` Arun Menon
2025-08-06 10:04 ` Marc-André Lureau
2025-08-06 10:19 ` Arun Menon
2025-08-05 18:25 ` [PATCH v9 21/27] migration: push Error **errp into loadvm_postcopy_handle_switchover_start() Arun Menon
2025-08-05 18:25 ` [PATCH v9 22/27] migration: Capture error in postcopy_ram_listen_thread() Arun Menon
2025-08-08 13:27 ` Fabiano Rosas
2025-08-05 18:25 ` [PATCH v9 23/27] migration: Refactor vmstate_save_state_v() function Arun Menon
2025-08-06 5:10 ` Akihiko Odaki
2025-08-06 8:19 ` Marc-André Lureau
2025-08-06 9:45 ` Arun Menon
2025-08-05 18:25 ` [PATCH v9 24/27] migration: Propagate last encountered error in " Arun Menon
2025-08-06 5:24 ` Akihiko Odaki
2025-08-07 6:07 ` Arun Menon
2025-08-05 18:25 ` [PATCH v9 25/27] migration: Remove error variant of vmstate_save_state() function Arun Menon
2025-08-06 8:28 ` Marc-André Lureau
2025-08-06 9:46 ` Arun Menon
2025-08-06 10:01 ` Marc-André Lureau
2025-08-06 10:30 ` Arun Menon
2025-08-06 11:16 ` Arun Menon
2025-08-05 18:25 ` [PATCH v9 26/27] migration: Add error-parameterized function variants in VMSD struct Arun Menon
2025-08-06 5:45 ` Akihiko Odaki
2025-08-06 7:27 ` Arun Menon
2025-08-05 18:25 ` [PATCH v9 27/27] backends/tpm: Propagate vTPM error on migration failure Arun Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734a22c93.fsf@suse.de \
--to=farosas@suse.de \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=armenon@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dmitry.osipenko@collabora.com \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=steven.sistare@oracle.com \
--cc=thuth@redhat.com \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).