qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@suse.de>
To: Peter Xu <peterx@redhat.com>
Cc: Nicholas Piggin <npiggin@gmail.com>,
	qemu-s390x@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Yury Kotov <yury-kotov@yandex-team.ru>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [RFC PATCH 3/3] tests/qtest/migration-test: Enable test_ignore_shared
Date: Mon, 27 May 2024 12:11:45 -0300	[thread overview]
Message-ID: <8734q3guha.fsf@suse.de> (raw)
In-Reply-To: <ZlSfNe6DhBgft79p@x1n>

Peter Xu <peterx@redhat.com> writes:

> On Mon, May 27, 2024 at 09:42:28AM -0300, Fabiano Rosas wrote:
>> However, there is an issue here still on all archs - which might very
>> well have been the original issue - which is the fact that the
>> containers on the Gitlab CI have limits on shared memory usage.
>> Unfortunately we cannot enable this test for the CI, so it needs a check
>> on the GITLAB_CI environment variable.
>
> Another option is we teach migration-test to detect whether memory_size of
> shmem is available, skip if not.  It can be a sequence of:
>
>   memfd_create()
>   fallocate()
>   ret = madvise(MADV_POPULATE_WRITE)
>
> To be run at the entry of migration-test, and skip all use_shmem=true tests
> if ret != 0, or any step failed above.

There are actually two issues:

1) Trying to run a test that needs more shmem than available in the
container. This is covered well by your suggestion.

2) Trying to use some shmem while another test has already consumed all
shmem. I'm not sure if this can be done reliably as the tests run in
parallel.


  reply	other threads:[~2024-05-27 15:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-25 13:12 [RFC PATCH 0/3] Fix s390x flic migration and add some more qtests Nicholas Piggin
2024-05-25 13:12 ` [RFC PATCH 1/3] hw/intc/s390_flic: Migrate pending state Nicholas Piggin
2024-05-26 15:53   ` David Hildenbrand
2024-05-26 19:44     ` Richard Henderson
2024-05-26 20:33       ` David Hildenbrand
2024-05-27  5:51         ` Thomas Huth
2024-05-27  7:11           ` Nicholas Piggin
2024-05-25 13:12 ` [RFC PATCH 2/3] tests/qtest/migration-test: enable on s390x Nicholas Piggin
2024-05-27  5:46   ` Prasad Pandit
2024-05-27  7:04     ` Nicholas Piggin
2024-05-27  7:40       ` Prasad Pandit
2024-05-25 13:12 ` [RFC PATCH 3/3] tests/qtest/migration-test: Enable test_ignore_shared Nicholas Piggin
2024-05-27 12:42   ` Fabiano Rosas
2024-05-27 14:56     ` Peter Xu
2024-05-27 15:11       ` Fabiano Rosas [this message]
2024-05-27 15:41         ` Peter Xu
2024-05-27  7:13 ` [RFC PATCH 0/3] Fix s390x flic migration and add some more qtests Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734q3guha.fsf@suse.de \
    --to=farosas@suse.de \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=yury-kotov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).