From: Fabiano Rosas <farosas@suse.de>
To: "Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Juan Quintela" <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
Leonardo Bras <leobras@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Markus Armbruster <armbru@redhat.com>,
Peter Xu <peterx@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
Fam Zheng <fam@euphon.net>, Stefan Hajnoczi <stefanha@redhat.com>,
Li Zhijian <lizhijian@fujitsu.com>, John Snow <jsnow@redhat.com>,
qemu-block@nongnu.org, Cleber Rosa <crosa@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script
Date: Wed, 22 May 2024 09:48:46 -0300 [thread overview]
Message-ID: <8734qahv0x.fsf@suse.de> (raw)
In-Reply-To: <3d437c79-89c0-4268-941f-0f97eb6d05b2@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 21/05/2024 14.46, Fabiano Rosas wrote:
>> Alex Bennée <alex.bennee@linaro.org> writes:
>>
>>> Juan Quintela <quintela@redhat.com> writes:
>>>
>>>> From: Fabiano Rosas <farosas@suse.de>
>>>>
>>>> Add a smoke test that migrates to a file and gives it to the
>>>> script. It should catch the most annoying errors such as changes in
>>>> the ram flags.
>>>>
>>>> After code has been merged it becomes way harder to figure out what is
>>>> causing the script to fail, the person making the change is the most
>>>> likely to know right away what the problem is.
>>>>
>>>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>>>> Acked-by: Thomas Huth <thuth@redhat.com>
>>>> Reviewed-by: Juan Quintela <quintela@redhat.com>
>>>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>>>> Message-ID: <20231009184326.15777-7-farosas@suse.de>
>>>
>>> I bisected the failures I'm seeing on s390x to the introduction of this
>>> script. I don't know if its simply a timeout on a relatively slow VM:
>>
>> What's the range of your bisect? That test has been disabled and then
>> reenabled on s390x. It could be tripping the bisect.
>>
>> 04131e0009 ("tests/qtest/migration-test: Disable the analyze-migration.py test on s390x")
>> 81c2c9dd5d ("tests/qtest/migration-test: Fix analyze-migration.py for s390x")
>>
>> I don't think that test itself could be timing out. It's a very simple
>> test. It runs a migration and then uses the output to validate the
>> script.
>
> Agreed, the analyze-migration.py is unlikely to be the issue - especially
> since it seems to have been disabled again in commit 6f0771de903b ...
> Fabiano, why did you disable it here again? The reason is not mentioned in
> the commit description.
Your patch 81c2c9dd5d was merged between my v1 and v2 on the list and I
didn't notice so I messed up the rebase. I'll send a patch soon to fix
that.
next prev parent reply other threads:[~2024-05-22 12:49 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 8:29 [PULL 00/38] Migration 20231017 patches Juan Quintela
2023-10-17 8:29 ` [PULL 01/38] migration: refactor migration_completion Juan Quintela
2023-10-17 8:29 ` [PULL 02/38] migration: Use g_autofree to simplify ram_dirty_bitmap_reload() Juan Quintela
2023-10-17 8:29 ` [PULL 03/38] migration: Allow user to specify available switchover bandwidth Juan Quintela
2023-10-17 8:29 ` [PULL 04/38] migration: fix RAMBlock add NULL check Juan Quintela
2023-10-17 8:29 ` [PULL 05/38] migration: Add the configuration vmstate to the json writer Juan Quintela
2023-10-17 8:29 ` [PULL 06/38] migration: Fix analyze-migration.py 'configuration' parsing Juan Quintela
2023-10-17 8:29 ` [PULL 07/38] migration: Add capability parsing to analyze-migration.py Juan Quintela
2023-10-17 8:29 ` [PULL 08/38] migration: Fix analyze-migration.py when ignore-shared is used Juan Quintela
2023-10-17 8:29 ` [PULL 09/38] migration: Fix analyze-migration read operation signedness Juan Quintela
2023-10-17 8:29 ` [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script Juan Quintela
2024-05-21 12:24 ` Alex Bennée
2024-05-21 12:46 ` Fabiano Rosas
2024-05-22 5:36 ` Thomas Huth
2024-05-22 12:48 ` Fabiano Rosas [this message]
2024-05-22 13:00 ` Thomas Huth
2024-05-22 14:11 ` Alex Bennée
2023-10-17 8:29 ` [PULL 11/38] tests/qtest: migration-test: Add tests for file-based migration Juan Quintela
2023-10-17 8:29 ` [PULL 12/38] migration: hold the BQL during setup Juan Quintela
2023-10-17 8:29 ` [PULL 13/38] migration: Non multifd migration don't care about multifd flushes Juan Quintela
2023-10-19 11:47 ` Michael Tokarev
2023-10-19 12:03 ` Juan Quintela
2023-10-17 8:29 ` [PULL 14/38] migration: Create migrate_rdma() Juan Quintela
2023-10-17 8:29 ` [PULL 15/38] migration/rdma: Unfold ram_control_before_iterate() Juan Quintela
2023-10-17 8:29 ` [PULL 16/38] migration/rdma: Unfold ram_control_after_iterate() Juan Quintela
2023-10-17 8:29 ` [PULL 17/38] migration/rdma: Remove all uses of RAM_CONTROL_HOOK Juan Quintela
2023-10-17 8:29 ` [PULL 18/38] migration/rdma: Unfold hook_ram_load() Juan Quintela
2023-10-17 8:29 ` [PULL 19/38] migration/rdma: Create rdma_control_save_page() Juan Quintela
2023-10-17 8:29 ` [PULL 20/38] qemu-file: Remove QEMUFileHooks Juan Quintela
2023-10-17 8:29 ` [PULL 21/38] migration/rdma: Move rdma constants from qemu-file.h to rdma.h Juan Quintela
2023-10-17 8:29 ` [PULL 22/38] migration/rdma: Remove qemu_ prefix from exported functions Juan Quintela
2023-10-17 8:29 ` [PULL 23/38] migration/rdma: Check sooner if we are in postcopy for save_page() Juan Quintela
2023-10-17 8:29 ` [PULL 24/38] migration/rdma: Use i as for index instead of idx Juan Quintela
2023-10-17 8:29 ` [PULL 25/38] migration/rdma: Declare for index variables local Juan Quintela
2023-10-17 8:29 ` [PULL 26/38] migration/rdma: Remove all "ret" variables that are used only once Juan Quintela
2023-10-17 8:29 ` [PULL 27/38] migration: Improve json and formatting Juan Quintela
2023-10-17 8:29 ` [PULL 28/38] migration: check for rate_limit_max for RATE_LIMIT_DISABLED Juan Quintela
2023-10-17 8:29 ` [PULL 29/38] multifd: fix counters in multifd_send_thread Juan Quintela
2023-10-17 8:29 ` [PULL 30/38] multifd: reset next_packet_len after sending pages Juan Quintela
2023-10-17 8:29 ` [PULL 31/38] migration/ram: Refactor precopy ram loading code Juan Quintela
2023-10-17 8:29 ` [PULL 32/38] migration/ram: Remove RAMState from xbzrle_cache_zero_page Juan Quintela
2023-10-17 8:29 ` [PULL 33/38] migration/ram: Stop passing QEMUFile around in save_zero_page Juan Quintela
2023-10-17 8:29 ` [PULL 34/38] migration/ram: Move xbzrle zero page handling into save_zero_page Juan Quintela
2023-10-17 8:30 ` [PULL 35/38] migration/ram: Merge save_zero_page functions Juan Quintela
2023-10-17 8:30 ` [PULL 36/38] migration/multifd: Remove direct "socket" references Juan Quintela
2023-10-17 8:30 ` [PULL 37/38] migration/multifd: Unify multifd_send_thread error paths Juan Quintela
2023-10-17 8:30 ` [PULL 38/38] migration/multifd: Clarify Error usage in multifd_channel_connect Juan Quintela
2023-10-17 19:04 ` [PULL 00/38] Migration 20231017 patches Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2023-10-16 10:06 [PULL 00/38] Migration 20231016 patches Juan Quintela
2023-10-16 10:06 ` [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734qahv0x.fsf@suse.de \
--to=farosas@suse.de \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=leobras@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).