From: Fabiano Rosas <farosas@suse.de>
To: Het Gala <het.gala@nutanix.com>, qemu-devel@nongnu.org
Cc: prerna.saxena@nutanix.com, quintela@redhat.com,
dgilbert@redhat.com, pbonzini@redhat.com, berrange@redhat.com,
armbru@redhat.com, eblake@redhat.com, manish.mishra@nutanix.com,
aravind.retnakaran@nutanix.com
Subject: Re: [PATCH v13 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration
Date: Thu, 19 Oct 2023 16:25:06 -0300 [thread overview]
Message-ID: <8734y676ul.fsf@suse.de> (raw)
In-Reply-To: <0967bdb1-6754-4b86-b552-acec84bd31bd@nutanix.com>
Het Gala <het.gala@nutanix.com> writes:
> On 18/10/23 7:58 pm, Fabiano Rosas wrote:
>> Het Gala <het.gala@nutanix.com> writes:
>>
>>> Fabiano, would your below commits impact this patchset 'make check'
>>> tests ? Because you have added tests for file based migration, which is
>>> still not included in this patchset.
>> AFAICS, the tests shouldn't break.
>>
> I tried two builds to run on Qemu CI/CD pipeline,
>
> Build without those two commits which involved file based migration -
> https://gitlab.com/galahet/Qemu/-/pipelines/1041554569
>
> Build with those two commits and only 2 patch of the current patchset -
> https://gitlab.com/galahet/Qemu/-/pipelines/1041215154
>
> I am not 100% certain but because the 'qtest/migration-test' test
> failed, I was of the view that might be because of those two commits.
I just sent a series on top of this one containing the additions for the
file transport support. Let's move the discussion there.
prev parent reply other threads:[~2023-10-19 19:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 15:10 [PATCH v13 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration Het Gala
2023-10-12 15:10 ` [PATCH v13 01/10] migration: New QAPI type 'MigrateAddress' Het Gala
2023-10-12 15:10 ` [PATCH v13 02/10] migration: convert migration 'uri' into 'MigrateAddress' Het Gala
2023-10-12 15:10 ` [PATCH v13 03/10] migration: convert socket backend to accept MigrateAddress Het Gala
2023-10-12 15:10 ` [PATCH v13 04/10] migration: convert rdma " Het Gala
2023-10-12 15:10 ` [PATCH v13 05/10] migration: convert exec " Het Gala
2023-10-12 15:10 ` [PATCH v13 06/10] migration: New migrate and migrate-incoming argument 'channels' Het Gala
2023-10-12 15:10 ` [PATCH v13 07/10] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax Het Gala
2023-10-12 15:10 ` [PATCH v13 08/10] migration: Implement MigrateChannelList to qmp migration flow Het Gala
2023-10-12 15:10 ` [PATCH v13 09/10] migration: Implement MigrateChannelList to hmp " Het Gala
2023-10-12 15:10 ` [PATCH v13 10/10] migration: modify test_multifd_tcp_none() to use new QAPI syntax Het Gala
2023-10-18 14:20 ` [PATCH v13 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration Het Gala
2023-10-18 14:28 ` Fabiano Rosas
2023-10-19 5:18 ` Het Gala
2023-10-19 19:25 ` Fabiano Rosas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734y676ul.fsf@suse.de \
--to=farosas@suse.de \
--cc=aravind.retnakaran@nutanix.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=het.gala@nutanix.com \
--cc=manish.mishra@nutanix.com \
--cc=pbonzini@redhat.com \
--cc=prerna.saxena@nutanix.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).