Re: [PATCH 1/5] configure: add qpl meson option

[Juan Quintela <quintela@redhat.com>]

Yuan Liu <yuan1.liu@intel.com> wrote:
> Intel Query Processing Library (QPL) is an open-source library that
> supports features of the new Intel In-Memory Analytics Accelerator (IAA)
> available on Intel Xeon Sapphire Rapids processors, including
> high-throughput compression and decompression.
>
> add --enable-qpl and --disable-qpl options for data (de)compression
> using IAA during the live migration process.
>
> Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
> Reviewed-by: Nanhai Zou <nanhai.zou@intel.com>
> @@ -2158,6 +2163,7 @@ config_host_data.set('CONFIG_MALLOC_TRIM', has_malloc_trim)
>  config_host_data.set('CONFIG_STATX', has_statx)
>  config_host_data.set('CONFIG_STATX_MNT_ID', has_statx_mnt_id)
>  config_host_data.set('CONFIG_ZSTD', zstd.found())
> +config_host_data.set('CONFIG_QPL', qpl.found())
>  config_host_data.set('CONFIG_FUSE', fuse.found())
>  config_host_data.set('CONFIG_FUSE_LSEEK', fuse_lseek.found())
>  config_host_data.set('CONFIG_SPICE_PROTOCOL', spice_protocol.found())
> @@ -3616,7 +3622,7 @@ libmigration = static_library('migration', sources: migration_files + genh,
>                                name_suffix: 'fa',
>                                build_by_default: false)
>  migration = declare_dependency(link_with: libmigration,
> -                               dependencies: [zlib, qom, io])
> +                               dependencies: [zlib, qom, io, qpl])

I think this is wrong.  Look how zstd is done.

You need to add something like this:

system_ss.add(when: zstd, if_true: files('multifd-zstd.c'))

to migration/meson.build

Or asking this other way, does this works if qpl is not there?  Or if
you compile for anything that is not x86?

Later, Juan.