From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0106C4321E for ; Mon, 28 Nov 2022 07:36:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozYgB-0000zv-Pp; Mon, 28 Nov 2022 02:35:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozYft-0000yB-Nj for qemu-devel@nongnu.org; Mon, 28 Nov 2022 02:35:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozYfr-0003Zj-JO for qemu-devel@nongnu.org; Mon, 28 Nov 2022 02:35:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669620929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l0p2wS9B+3emiEGvgDHo5SKzpkD2eq6DcFtWZ3RjSL8=; b=BUm4TVLaRDB2epOsq1C+JbZDZtmKRBMg2GxPmtoIf1I+7Le4VoE+K4iEUpWuUdQ1qlCYpb zfS9NiwA/UzHqclt8kQat0WqovS1JEH8Y8GwOOtH1cfH3Siuc9kkR7BZjMNbfHkkAsHDt5 94iwPejjpnCaPy7YlywBfjall2mtBGA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-9hw7Jd0EMsGCnxScBVjINw-1; Mon, 28 Nov 2022 02:35:26 -0500 X-MC-Unique: 9hw7Jd0EMsGCnxScBVjINw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B2613811E75; Mon, 28 Nov 2022 07:35:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5CEC32166B2B; Mon, 28 Nov 2022 07:35:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 100CF21E6921; Mon, 28 Nov 2022 08:35:22 +0100 (CET) From: Markus Armbruster To: Greg Kurz Cc: qemu-devel@nongnu.org, Christian Schoenebeck Subject: Re: [PATCH] 9pfs: Fix some return statements in the synth backend References: <166930551818.827792.10663674346122681963.stgit@bahia> Date: Mon, 28 Nov 2022 08:35:22 +0100 In-Reply-To: <166930551818.827792.10663674346122681963.stgit@bahia> (Greg Kurz's message of "Thu, 24 Nov 2022 16:58:38 +0100") Message-ID: <8735a3y1j9.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Greg Kurz writes: > The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions > currently return a positive errno value on failure. This causes > checkpatch.pl to spit several errors like the one below: > > ERROR: return of an errno should typically be -ve (return -EAGAIN) > #79: FILE: hw/9pfs/9p-synth.c:79: > + return EAGAIN; > > Simply change the sign. This has no consequence since callers > assert() the returned value to be equal to 0. Out of curiosity: why is assert() appropriate? > While here also get rid of the uneeded ret variables as suggested > by return_directly.cocci. > > Reported-by: Markus Armbruster > Signed-off-by: Greg Kurz Signed-off-by: Markus Armbruster