From: Juan Quintela <quintela@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Leonardo Bras Soares Passos" <lsoaresp@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 03/11] multifd: Fill offset and block for reception
Date: Mon, 22 Nov 2021 10:26:54 +0100 [thread overview]
Message-ID: <8735nor15t.fsf@secure.mitica> (raw)
In-Reply-To: <cd4f7997-7860-8145-0200-ad0d7df92c6c@linaro.org> (Richard Henderson's message of "Sat, 20 Nov 2021 13:26:43 +0100")
Richard Henderson <richard.henderson@linaro.org> wrote:
> On 11/19/21 5:58 PM, Juan Quintela wrote:
>> We were using the iov directly, but we will need this info on the
>> following patch.
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>> migration/multifd.c | 2 ++
>> 1 file changed, 2 insertions(+)
>> diff --git a/migration/multifd.c b/migration/multifd.c
>> index 7c9deb1921..e2adcdffa1 100644
>> --- a/migration/multifd.c
>> +++ b/migration/multifd.c
>> @@ -364,6 +364,8 @@ static int multifd_recv_unfill_packet(MultiFDRecvParams *p, Error **errp)
>> offset, block->used_length);
>> return -1;
>> }
>> + p->pages->offset[i] = offset;
>> + p->pages->block = block;
>> p->pages->iov[i].iov_base = block->host + offset;
>> p->pages->iov[i].iov_len = qemu_target_page_size();
>> }
>>
>
> Block should be stored one outside the loop.
Done.
Thanks, Juan.
next prev parent reply other threads:[~2021-11-22 9:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 16:58 [PATCH 00/11] migration: Make multifd use only one write on the send path Juan Quintela
2021-11-19 16:58 ` [PATCH 01/11] migration: Remove is_zero_range() Juan Quintela
2021-11-20 12:24 ` Richard Henderson
2021-11-19 16:58 ` [PATCH 02/11] dump: Remove is_zero_page() Juan Quintela
2021-11-20 12:25 ` Richard Henderson
2021-11-21 19:30 ` Marc-André Lureau
2021-11-19 16:58 ` [PATCH 03/11] multifd: Fill offset and block for reception Juan Quintela
2021-11-20 12:26 ` Richard Henderson
2021-11-22 9:26 ` Juan Quintela [this message]
2021-11-19 16:58 ` [PATCH 04/11] multifd: Make zstd compression method not use iovs Juan Quintela
2021-11-19 16:58 ` [PATCH 05/11] multifd: Make zlib " Juan Quintela
2021-11-19 16:58 ` [PATCH 06/11] migration: Move iov from pages to params Juan Quintela
2021-11-20 12:31 ` Richard Henderson
2021-11-22 9:31 ` Juan Quintela
2021-11-19 16:58 ` [PATCH 07/11] multifd: Make zlib use iov's Juan Quintela
2021-11-19 16:59 ` [PATCH 08/11] multifd: Make zstd " Juan Quintela
2021-11-19 16:59 ` [PATCH 09/11] multifd: Remove send_write() method Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735nor15t.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).