From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 251D0C48BE5 for ; Tue, 22 Jun 2021 10:42:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF07C600D1 for ; Tue, 22 Jun 2021 10:42:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF07C600D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvdr1-0000Y8-04 for qemu-devel@archiver.kernel.org; Tue, 22 Jun 2021 06:42:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvdkN-00065R-Au for qemu-devel@nongnu.org; Tue, 22 Jun 2021 06:35:11 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:38700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lvdkJ-00089U-Cs for qemu-devel@nongnu.org; Tue, 22 Jun 2021 06:35:10 -0400 Received: by mail-wr1-x436.google.com with SMTP id h11so5547907wrx.5 for ; Tue, 22 Jun 2021 03:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:message-id :in-reply-to:mime-version:content-transfer-encoding; bh=N6/7Sb/XRbFSQUER1TXS53KQTORmXTcFJxkgP/h/w3U=; b=pEA+NJvJ4vw8hRHwPZbEKZdEDrbZHCPU/ob91UhOpOOSKjYrlOHo2W0ss4J5eKJFJd HiA33uTwMiPgzrGGMEJkevndOCd8OhH5llr2ACG27Zgbl3PsT5rHO7LC1o0pRkzxLjEJ qqfQrdSkhEy2cth/7umgy5+QhkhR8bf1RMSTllHUCHo+9PZ7XC4YSULSeenWjdlSGJSe WJBmY1MrR0yOsvkNoE1nLO40CUwNChR/cLYZk3vzmQf8WQQ95tesfpEdwXM7HRLMIJX0 bXU++A4tnciolyE+wRXn3UkfPRPSSHdMsrH+obLRlCzDkfIr2NbbWb0neMFL0GXkvkoF mmCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :message-id:in-reply-to:mime-version:content-transfer-encoding; bh=N6/7Sb/XRbFSQUER1TXS53KQTORmXTcFJxkgP/h/w3U=; b=m45eyAd89Md7C6NDYz+G2J2goumooFO1b0uHbXf/AwJI7Fg1A1gG42AU910slFhk0B nvWSRtpnHR2gywgqpbH/1SbXyPYViJj0JgPf8Sdlvwvqh58eHJJtmCWol7rF+fvEDUVH ieiHftIC8kcqDlKVBOYtQl93Os03aBe1TED184hPmhCMtEefmjxwJfF4H/w4yvXLp1aj QUEXNjeNsh0Ep8T8rSu1uE9uHjfPZ236+PowVEYG/s5y8ahbD+ZofND8TGjWLGaOIYti ng3H3pxyE6eY1a9qNCRZUgIjyb2c5M1gTr/2Hg4L78nxdDnwAV6EjQEEeaY88OhhDR1z WyvA== X-Gm-Message-State: AOAM532tj5c5jyQ4sTqebmPyAhUnzQBJmLVF6LD3vrq4OUUQEfJyUlyC w46X5v9jvjrTMvXcCxVTfPSKdA== X-Google-Smtp-Source: ABdhPJxoeZ/yVlLeGCi65lfvkywEXmriI6/6H/pV2XAiBI4yci+4ywwmRutaJHrk5+UdOwxKBBAeCA== X-Received: by 2002:adf:de87:: with SMTP id w7mr3858890wrl.333.1624358105161; Tue, 22 Jun 2021 03:35:05 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id r1sm2029840wmn.10.2021.06.22.03.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 03:35:04 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5D3091FF7E; Tue, 22 Jun 2021 11:35:03 +0100 (BST) References: <20210618091101.2802534-1-erdnaxe@crans.org> <20210618091101.2802534-2-erdnaxe@crans.org> <871r8uthe1.fsf@linaro.org> User-agent: mu4e 1.5.13; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Alexandre IOOSS Subject: Re: [PATCH v2 1/2] contrib/plugins: add execlog to log instruction execution and memory access Date: Tue, 22 Jun 2021 11:33:11 +0100 Message-ID: <8735tatcfm.fsf@linaro.org> In-reply-to: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mahmoud Mandour , "open list : All patches CC here" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Alexandre IOOSS writes: > [[PGP Signed Part:Undecided]] > On 6/22/21 10:37 AM, Alex Benn=C3=A9e wrote: >> We only allocate last_exec for system.max_vcpus here. You need to check >> the system_emulation bool before using that information and error out if >> it's not system emulation. > > My bad, I did not test user mode emulation after converting last_exec > to an array. Should I consider only one vCPU in user mode emulation? It's up to you. The cpuid is essentially unbounded for linux-user so you could either dynamically assign new entries as they come up or just not load for non system emulation cases. If you attempt to run multi-threaded programs with a single entry in the array you will get weird interleaving issues. > > -- Alexandre > > [[End of PGP Signed Part]] --=20 Alex Benn=C3=A9e